Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1689)

Unified Diff: Source/core/workers/WorkerGlobalScope.h

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/WorkerGlobalScope.h
diff --git a/Source/core/workers/WorkerGlobalScope.h b/Source/core/workers/WorkerGlobalScope.h
index 1324e74dc69aa330e91734a9c5fafa6e4b9b1406..8a2c0f2770efd967201315b0e78de9a70965126d 100644
--- a/Source/core/workers/WorkerGlobalScope.h
+++ b/Source/core/workers/WorkerGlobalScope.h
@@ -142,8 +142,8 @@ namespace WebCore {
WorkerGlobalScope(const KURL&, const String& userAgent, WorkerThread*, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerClients>);
void applyContentSecurityPolicyFromString(const String& contentSecurityPolicy, ContentSecurityPolicyHeaderType);
- virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) OVERRIDE;
- void addMessageToWorkerConsole(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>, ScriptState*);
+ virtual void logExceptionToConsole(PassRefPtr<ConsoleMessage>) OVERRIDE;
+ void addMessageToWorkerConsole(PassRefPtr<ConsoleMessage>);
private:
#if !ENABLE(OILPAN)
@@ -155,7 +155,7 @@ namespace WebCore {
virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL;
virtual void reportBlockedScriptExecutionToInspector(const String& directiveText) OVERRIDE FINAL;
- virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState* = 0) OVERRIDE FINAL;
+ virtual void addMessage(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
virtual EventTarget* errorEventTarget() OVERRIDE FINAL;
virtual void didUpdateSecurityOrigin() OVERRIDE FINAL { }

Powered by Google App Engine
This is Rietveld 408576698