Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: Source/core/workers/SharedWorkerGlobalScope.cpp

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/SharedWorkerGlobalScope.cpp
diff --git a/Source/core/workers/SharedWorkerGlobalScope.cpp b/Source/core/workers/SharedWorkerGlobalScope.cpp
index bd1f42a322275bb000cf64831f3c2013b7fdf28f..7dd32288f1513daaa5cb36abe4ec616a5219ab3a 100644
--- a/Source/core/workers/SharedWorkerGlobalScope.cpp
+++ b/Source/core/workers/SharedWorkerGlobalScope.cpp
@@ -33,8 +33,9 @@
#include "core/workers/SharedWorkerGlobalScope.h"
#include "core/events/MessageEvent.h"
-#include "core/inspector/ScriptCallStack.h"
#include "core/frame/LocalDOMWindow.h"
+#include "core/inspector/ConsoleMessage.h"
+#include "core/inspector/ScriptCallStack.h"
#include "core/workers/SharedWorkerThread.h"
#include "core/workers/WorkerClients.h"
#include "wtf/CurrentTime.h"
@@ -78,10 +79,11 @@ SharedWorkerThread* SharedWorkerGlobalScope::thread()
return static_cast<SharedWorkerThread*>(Base::thread());
}
-void SharedWorkerGlobalScope::logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)
+void SharedWorkerGlobalScope::logExceptionToConsole(PassRefPtr<ConsoleMessage> prpConsoleMessage)
{
- WorkerGlobalScope::logExceptionToConsole(errorMessage, sourceURL, lineNumber, columnNumber, callStack);
- addMessageToWorkerConsole(JSMessageSource, ErrorMessageLevel, errorMessage, sourceURL, lineNumber, callStack, 0);
+ RefPtr<ConsoleMessage> consoleMessage = prpConsoleMessage;
+ WorkerGlobalScope::logExceptionToConsole(consoleMessage);
+ addMessageToWorkerConsole(consoleMessage.release());
}
void SharedWorkerGlobalScope::trace(Visitor* visitor)

Powered by Google App Engine
This is Rietveld 408576698