Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: Source/core/frame/FrameConsole.h

Issue 376213002: DevTools: Make FrameConsole methods accept ConsoleMessage objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@scriptFailedToParse
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameConsole.h
diff --git a/Source/core/frame/FrameConsole.h b/Source/core/frame/FrameConsole.h
index a2a14f058468fb21455890641abe27cc92a8b21a..c01e50790c5d987f91f2f2ece8cd7605f3bf39ae 100644
--- a/Source/core/frame/FrameConsole.h
+++ b/Source/core/frame/FrameConsole.h
@@ -37,6 +37,7 @@
namespace WebCore {
+class ConsoleMessage;
class FrameHost;
// FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
@@ -45,9 +46,7 @@ class FrameConsole FINAL {
public:
static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr(new FrameConsole(frame)); }
- void addMessage(MessageSource, MessageLevel, const String& message);
- void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, unsigned columnNumber = 0, PassRefPtrWillBeRawPtr<ScriptCallStack> = nullptr, ScriptState* = 0, unsigned long requestIdentifier = 0);
- void addMessage(MessageSource, MessageLevel, const String& message, PassRefPtrWillBeRawPtr<ScriptCallStack>);
+ void addMessage(PassRefPtr<ConsoleMessage>);
static String formatStackTraceString(const String& originalMessage, PassRefPtrWillBeRawPtr<ScriptCallStack>);
static void mute();

Powered by Google App Engine
This is Rietveld 408576698