extensions/browser/guest_view/guest_view_base.cc - Issue 376033002: Adding MimeHandlerView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.cc

Issue 376033002: Adding MimeHandlerView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pending-zork-patch2

Patch Set: add (c) header Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_base.cc

diff --git a/extensions/browser/guest_view/guest_view_base.cc b/extensions/browser/guest_view/guest_view_base.cc

index cdf9f0a04a1520cac457f6ede2c2675c1185b77f..3c2fe361203ca86702cebbf235d7e6d04a4c61f2 100644

--- a/extensions/browser/guest_view/guest_view_base.cc

+++ b/extensions/browser/guest_view/guest_view_base.cc

@@ -132,8 +132,9 @@ void GuestViewBase::Init(const std::string& embedder_extension_id,

embedder_process_id),

embedder_web_contents->GetLastCommittedURL());

if (!availability.is_available()) {

- callback.Run(NULL);

- return;

+ // TODO(lazyboy): Fix api feature stuff.

+ //callback.Run(NULL);

Fady Samuel 2014/09/02 15:08:25 This commenting out should be unnecessary if you c

lazyboy 2014/09/02 20:17:22 Done.

+ //return;

}

CreateWebContents(embedder_extension_id,