Adding MimeHandlerView.

content/renderer/browser_plugin/browser_plugin.cc

Index: content/renderer/browser_plugin/browser_plugin.cc
diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc
index 4bd18307617782f42cb7ec55573853cb7097de1c..edba44d8e67063e1a1beb5fabdd21f3b3ee8ddd5 100644
--- a/content/renderer/browser_plugin/browser_plugin.cc
+++ b/content/renderer/browser_plugin/browser_plugin.cc
@@ -13,6 +13,7 @@
 #include "content/common/view_messages.h"
 #include "content/public/common/content_client.h"
 #include "content/public/common/content_switches.h"
+#include "content/public/renderer/browser_plugin_delegate.h"
 #include "content/public/renderer/content_renderer_client.h"
 #include "content/renderer/browser_plugin/browser_plugin_bindings.h"
 #include "content/renderer/browser_plugin/browser_plugin_manager.h"
@@ -44,7 +45,7 @@ namespace content {
 
 BrowserPlugin::BrowserPlugin(RenderViewImpl* render_view,
                              blink::WebFrame* frame,
-                             bool auto_navigate)
+                             BrowserPluginDelegate* delegate)
     : attached_(false),
       attach_pending_(false),
       render_view_(render_view->AsWeakPtr()),
@@ -57,10 +58,10 @@ BrowserPlugin::BrowserPlugin(RenderViewImpl* render_view,
       content_window_routing_id_(MSG_ROUTING_NONE),
       plugin_focused_(false),
       visible_(true),
-      auto_navigate_(auto_navigate),
       mouse_locked_(false),
       browser_plugin_manager_(render_view->GetBrowserPluginManager()),
       browser_plugin_instance_id_(browser_plugin::kInstanceIDNone),
+      delegate_(delegate),
       weak_ptr_factory_(this) {
 }
 
@@ -397,6 +398,10 @@ bool BrowserPlugin::initialize(WebPluginContainer* container) {
   // This is a way to notify observers of our attributes that this plugin is
   // available in render tree.
   browser_plugin_instance_id_ = browser_plugin_manager()->GetNextInstanceID();
+
+  if (delegate_)
+    delegate_->SetElementInstanceID(browser_plugin_instance_id_);

[Fady Samuel, 2014/09/02 15:08:25]

Given that we make use of the element instance ID in ChromeBrowserPluginDelegate
and we don't have guards against invalid IDs in ChromeBrowserPluginDelegate, I
worry that the code might be racy or might introduce races in the future.


I see two solutions:

1. Add guards for using element_instance_id in ChromeBrowserPluginDelegate OR
2. Allocate the element instance ID in the constructor instead of on initialize.

I would prefer 2. In other words: Move the three lines above into the
constructor.

[lazyboy, 2014/09/02 20:17:22]

Done #2.

+
   UpdateDOMAttribute("internalinstanceid",

[Fady Samuel, 2014/09/02 15:08:25]

You don't have to do this in this CL but it occurs to me that if we have a
delegate, we might not need this anymore. Perhaps the delegate can fire an
extension event that informs web_view.js (and other GuestView custom elements)
of the BrowserPlugin's unique ID.

Perhaps a TODO about how maybe we don't need this DOM attribute and instead we
can carry the element ID to the content embedder through the delegate.

[lazyboy, 2014/09/02 20:17:22]

Added TODO.

                      base::IntToString(browser_plugin_instance_id_));
 
@@ -699,17 +704,13 @@ void BrowserPlugin::didReceiveResponse(
 }
 
 void BrowserPlugin::didReceiveData(const char* data, int data_length) {
-  if (auto_navigate_) {
-    std::string value(data, data_length);
-    html_string_ += value;
-  }
+  if (delegate_)
+    delegate_->DidReceiveData(data, data_length);
 }
 
 void BrowserPlugin::didFinishLoading() {
-  if (auto_navigate_) {
-    // TODO(lazyboy): Make |auto_navigate_| stuff work.
-    UpdateDOMAttribute(content::browser_plugin::kAttributeSrc, html_string_);
-  }
+  if (delegate_)
+    delegate_->DidFinishLoading();
 }
 
 void BrowserPlugin::didFailLoading(const blink::WebURLError& error) {