Issue 36833002: Fix bugs in Sodium

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 36833002: Fix bugs in Sodium (Closed)

Created:
7 years, 2 months ago by danno

Modified:
7 years, 2 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bugs in Sodium R=dslomov@chromium.org

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review feedback #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
M	src/codegen.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/objects.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/sodium/sodium.js	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dmitry Lomov (no reviews)

7 years, 2 months ago (2013-10-23 09:06:50 UTC) #2

LGTM with a suggestion (up to you whether to act on it or not)

https://chromiumcodereview.appspot.com/36833002/diff/1/tools/sodium/sodium.js
File tools/sodium/sodium.js (right):

https://chromiumcodereview.appspot.com/36833002/diff/1/tools/sodium/sodium.js...
tools/sodium/sodium.js:345: var newHtml = "<pre class=\"prettyprint linenums\"
id=\"source-text-pre\">"
Construct this with createElement instead of HTML string?

Expand Messages | Collapse Messages