Try Dart 1 hour experience first draft

adding source files for Seth to review


roughing out the try dart experience


steps 0,1,2 for new trydart code lab


Merge branch 'master' into trydart


skeleton to try out a new trydart tute

BUG=
R=sethladd@google.com

Committed: 995f777

[sethladd, 2013-10-22 20:19:05]

more to come

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
File src/site/articles/trydart/code/piratebadge.dart (right):

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:6: // Demonstrates:
love the comments in here. Let's link to a doc from here so they can learn more
about these things.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:29:
query('#badgeName').onChange.listen(storePirateName);
my mistake, this doesn't work. Can we try a setter that changes the text and
stores in storage?

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:32: (query('#generateButton') as
ButtonElement).disabled = false;
de-dupe these queries and create variables above

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:33: (query('#inputName') as
InputElement).disabled = false;
can the HTML start as disabled?

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:36: query('#badgeName').text =
new PirateName.fromJSON(window.localStorage[TREASUREKEY]).pirateName;
create a getter for new PirateName.fromJSON(window.localStorage[TRE
     ASUREKEY]).pirateName

[sethladd, 2013-10-22 20:29:14]

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
File src/site/articles/trydart/code/piratebadge.dart (right):

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:39: print ('Error reading JSON
file: $error');
the error is more generic than "reading JSON"

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:40: query('#badgeName').text =
'Arrr! No names.';
pull query out from here

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:48: query('#badgeName').text =
new PirateName(firstName: inputName).pirateName;
if you use query like this through the code, you can use top-level variables.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:49: if (inputName == '') {
inputName.trim().isEmpty

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:78: PirateName({String
firstName}) {
why not appellation ?

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:87: PirateName.fromJSON(String
jsonString){
space before {

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:89: List splitName =
storedName.split(' ');
why not store the first name and appellation as separate fields? that why you
don't have to parse a string. which is kind of yucky

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:94: static List<String> names =
[];
I think these should go up where the other statics are

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:97: static Future initialize() {
initialize is really generic. is there a more descriptive name?

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:101: static Future
makeRequest(/*Event e*/) {
how about moving the contents from this method up to initialize? all initialize
does is call this method

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:107: static
parsePirateNamesFromJSON(String jsonString) {
make this a private method

[mem, 2013-10-22 21:39:43]

Thank you so much seth. The code is much better.

I made all your changes.

Let me know fi you find anything else. Otherwise, I shall proceed apace.

mem

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
File src/site/articles/trydart/code/piratebadge.dart (right):

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:6: // Demonstrates:
I can link to the doc once it has a home. Also, it might be worth a separate
readme or walk-through or concepts.

On 2013/10/22 20:19:06, sethladd wrote:
> love the comments in here. Let's link to a doc from here so they can learn
more
> about these things.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:29:
query('#badgeName').onChange.listen(storePirateName);
On 2013/10/22 20:19:06, sethladd wrote:
> my mistake, this doesn't work. Can we try a setter that changes the text and
> stores in storage?

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:32: (query('#generateButton') as
ButtonElement).disabled = false;
On 2013/10/22 20:19:06, sethladd wrote:
> de-dupe these queries and create variables above

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:33: (query('#inputName') as
InputElement).disabled = false;
they *DO* start as disabled.
this is enabling them....

On 2013/10/22 20:19:06, sethladd wrote:
> can the HTML start as disabled?

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:36: query('#badgeName').text =
new PirateName.fromJSON(window.localStorage[TREASUREKEY]).pirateName;
On 2013/10/22 20:19:06, sethladd wrote:
> create a getter for new PirateName.fromJSON(window.localStorage[TRE
>      ASUREKEY]).pirateName

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:39: print ('Error reading JSON
file: $error');
On 2013/10/22 20:29:15, sethladd wrote:
> the error is more generic than "reading JSON"

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:40: query('#badgeName').text =
'Arrr! No names.';
On 2013/10/22 20:29:15, sethladd wrote:
> pull query out from here

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:48: query('#badgeName').text =
new PirateName(firstName: inputName).pirateName;
On 2013/10/22 20:29:15, sethladd wrote:
> if you use query like this through the code, you can use top-level variables.

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:49: if (inputName == '') {
On 2013/10/22 20:29:15, sethladd wrote:
> inputName.trim().isEmpty

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:78: PirateName({String
firstName}) {
On 2013/10/22 20:29:15, sethladd wrote:
> why not appellation ?

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:87: PirateName.fromJSON(String
jsonString){
On 2013/10/22 20:29:15, sethladd wrote:
> space before {

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:89: List splitName =
storedName.split(' ');
On 2013/10/22 20:29:15, sethladd wrote:
> why not store the first name and appellation as separate fields? that why you
> don't have to parse a string. which is kind of yucky

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:89: List splitName =
storedName.split(' ');
On 2013/10/22 20:29:15, sethladd wrote:
> why not store the first name and appellation as separate fields? that why you
> don't have to parse a string. which is kind of yucky

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:89: List splitName =
storedName.split(' ');
On 2013/10/22 20:29:15, sethladd wrote:
> why not store the first name and appellation as separate fields? that why you
> don't have to parse a string. which is kind of yucky

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:94: static List<String> names =
[];
On 2013/10/22 20:29:15, sethladd wrote:
> I think these should go up where the other statics are

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:97: static Future initialize() {
On 2013/10/22 20:29:15, sethladd wrote:
> initialize is really generic. is there a more descriptive name?

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:101: static Future
makeRequest(/*Event e*/) {
On 2013/10/22 20:29:15, sethladd wrote:
> how about moving the contents from this method up to initialize? all
initialize
> does is call this method

Done.

https://chromiumcodereview.appspot.com/35913002/diff/1/src/site/articles/tryd...
src/site/articles/trydart/code/piratebadge.dart:107: static
parsePirateNamesFromJSON(String jsonString) {
On 2013/10/22 20:29:15, sethladd wrote:
> make this a private method

Done.

[sethladd, 2013-10-22 21:59:17]

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
File src/site/articles/trydart/code/piratebadge.dart (right):

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:36: print ('Error initializing
pirate names: $err');
remove space between print and (

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:41: get pirateNameFromStorage {
add return type annotation

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:45: }
add explicit return null for else

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:49: query('#badgeName').text =
newName.pirateName;
you have query('#badgeName') twice in the code. please extract into variable

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:55: ButtonElement genButton =
query('#generateButton');
put this variable into top level so you don't need to query twice (here and
main)

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:67: void generateBadge(Event e)
{
I don't see this called from anywhere

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:85: PirateName({String
firstName, String appellation}) {
typically constructor goes after the fields

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:98: String toJsonString() => '{
"f": "$_firstName", "a": "$_appellation" } ';
then move this down under constructors

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:107: var path =
'piratenames.json';
use String instead of var, since you use type annotations everywhere else. Or,
pick one style :)

Also, optionally pass in the file name into the method

[mem, 2013-10-22 23:06:24]

Thanks.
mem

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
File src/site/articles/trydart/code/piratebadge.dart (right):

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:36: print ('Error initializing
pirate names: $err');
On 2013/10/22 21:59:17, sethladd wrote:
> remove space between print and (

Done.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:41: get pirateNameFromStorage {
On 2013/10/22 21:59:17, sethladd wrote:
> add return type annotation

Done.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:45: }
On 2013/10/22 21:59:17, sethladd wrote:
> add explicit return null for else

Done.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:49: query('#badgeName').text =
newName.pirateName;
On 2013/10/22 21:59:17, sethladd wrote:
> you have query('#badgeName') twice in the code. please extract into variable

Done.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:55: ButtonElement genButton =
query('#generateButton');
On 2013/10/22 21:59:17, sethladd wrote:
> put this variable into top level so you don't need to query twice (here and
> main)

Done.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:67: void generateBadge(Event e)
{
On 2013/10/22 21:59:17, sethladd wrote:
> I don't see this called from anywhere

this is the event handler for the button.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:85: PirateName({String
firstName, String appellation}) {
On 2013/10/22 21:59:17, sethladd wrote:
> typically constructor goes after the fields

Done.

https://chromiumcodereview.appspot.com/35913002/diff/350001/src/site/articles...
src/site/articles/trydart/code/piratebadge.dart:98: String toJsonString() => '{
"f": "$_firstName", "a": "$_appellation" } ';
On 2013/10/22 21:59:17, sethladd wrote:
> then move this down under constructors

Done.

[mem, 2013-10-23 20:54:45]

I think the CL is complete even though I got another error from git cl upload
about the base files missing. What's up with that?

Anyway, I have a first draft now from Step 0 - What's next?

https://tute-proto-trydart-dot-dart-lang.appspot.com/articles/trydart/

Critique away. Accepting all comments...major and minor.

The goal is to do a soft release of this on Friday.'

Thanks.
mem

[sethladd, 2013-10-23 21:15:05]

https://chromiumcodereview.appspot.com/35913002/diff/2020001/src/site/article...
File src/site/articles/trydart/index.markdown (right):

https://chromiumcodereview.appspot.com/35913002/diff/2020001/src/site/article...
src/site/articles/trydart/index.markdown:195: is programmatically updated by the
Dart code
you don't show the updating here. How about "is used to display the name. The
text will be programmatically updated in a later step."

https://chromiumcodereview.appspot.com/35913002/diff/2020001/src/site/article...
src/site/articles/trydart/index.markdown:223: * This file is included in the
HTML file
it's not included, it's referenced by the main HTML file. Or, "this is the
script for the app"

[mem, 2013-10-25 18:36:22]

A fresh new version is now available.

https://tute-proto-trydart-dot-dart-lang.appspot.com/articles/trydart/

mem

[sethladd, 2013-10-25 18:44:42]

as we discussed offline, please move this out of articles. Perhaps codelabs ?

[sethladd, 2013-10-25 18:48:29]

Also, where is the finished app? I see steps 1 - 6 but can we make it clearer
which is the one to run if I just want to see it work?

"What Next?" should be declarative.

"library dependencies" is probably "package dependencies"

[mem, 2013-11-05 19:12:12]

Is this ready to go out? Arrrr.

https://tute-proto-trydart-dot-dart-lang.appspot.com/codelabs/darrrt/

Also deleting old codelab and redirecting to new one.

[sethladd, 2013-11-05 19:15:32]

lgtm

[mem, 2013-11-05 20:56:57]

Committed patchset #21 manually as r995f777 (presubmit successful).