"Fix" dart:js tests in IE9

"Fix" dart:js tests in IE9



BUG=
R=jacobr@google.com

Committed: https://code.google.com/p/dart/source/detail?r=29125

[Jacob, 2013-10-23 05:15:05]

https://codereview.chromium.org/35173004/diff/1/tests/html/js_test.dart
File tests/html/js_test.dart (right):

https://codereview.chromium.org/35173004/diff/1/tests/html/js_test.dart#newco...
tests/html/js_test.dart:183: // Some test are either causing other test to fail
in IE9, or they are failing
add a bug# to track down the real cause.

https://codereview.chromium.org/35173004/diff/1/tests/html/js_test.dart#newco...
tests/html/js_test.dart:459: //
expect(node.instanceof(context['HTMLDivElement']), isTrue);
i would remove instanceof based checks.  JS instanceof is really flaky and
nobody relies on it . Perhaps instead just do some duck typing checks such as
validate that the class has an innerHTML, addEventListener method, etc.
Those sorts of checks are much more likely to work cross browser.

[Jacob, 2013-10-23 05:15:25]

lgtm once comments are addressed.

[justinfagnani, 2013-10-23 21:13:18]

Committed patchset #1 manually as r29125 (presubmit successful).

[justinfagnani, 2013-10-23 21:23:57]

https://chromiumcodereview.appspot.com/35173004/diff/1/tests/html/js_test.dart
File tests/html/js_test.dart (right):

https://chromiumcodereview.appspot.com/35173004/diff/1/tests/html/js_test.dar...
tests/html/js_test.dart:183: // Some test are either causing other test to fail
in IE9, or they are failing
On 2013/10/23 05:15:05, Jacob wrote:
> add a bug# to track down the real cause.

Done.

https://chromiumcodereview.appspot.com/35173004/diff/1/tests/html/js_test.dar...
tests/html/js_test.dart:459: //
expect(node.instanceof(context['HTMLDivElement']), isTrue);
On 2013/10/23 05:15:05, Jacob wrote:
> i would remove instanceof based checks.  JS instanceof is really flaky and
> nobody relies on it . Perhaps instead just do some duck typing checks such as
> validate that the class has an innerHTML, addEventListener method, etc.
> Those sorts of checks are much more likely to work cross browser.

I'm going to do an overhaul of this test in it's own CL so that it's easy to
review independent of other changes. I'll remove the instanceof checks then.