Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Unified Diff: chrome/browser/history/history_backend.cc

Issue 351053003: Port HistoryService::QueryFilteredURLs to CancelableRequestTracker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/history_backend.cc
diff --git a/chrome/browser/history/history_backend.cc b/chrome/browser/history/history_backend.cc
index d82ebb7d0c79287a280cceb46833d4634a0ab20a..41059d60ccdd7948bd536b84a1b43c8fc185102e 100644
--- a/chrome/browser/history/history_backend.cc
+++ b/chrome/browser/history/history_backend.cc
@@ -1348,19 +1348,16 @@ void HistoryBackend::QueryMostVisitedURLs(int result_count,
}
}
-void HistoryBackend::QueryFilteredURLs(
- scoped_refptr<QueryFilteredURLsRequest> request,
- int result_count,
- const history::VisitFilter& filter,
- bool extended_info) {
- if (request->canceled())
- return;
-
+void HistoryBackend::QueryFilteredURLs(int result_count,
+ const history::VisitFilter& filter,
+ bool extended_info,
+ history::FilteredURLList* result) {
+ DCHECK(result);
base::Time request_start = base::Time::Now();
+ result->clear();
if (!db_) {
// No History Database - return an empty list.
- request->ForwardResult(request->handle(), FilteredURLList());
return;
}
@@ -1397,7 +1394,6 @@ void HistoryBackend::QueryFilteredURLs(
}
}
- FilteredURLList& result = request->value;
for (size_t i = 0; i < data.size(); ++i) {
PageUsageData* current_data = data[i];
FilteredURL url(*current_data);
@@ -1417,7 +1413,7 @@ void HistoryBackend::QueryFilteredURLs(
// TODO(macourteau): implement the url.extended_info.visits stat.
}
}
- result.push_back(url);
+ result->push_back(url);
}
int delta_time = std::max(1, std::min(999,
@@ -1427,8 +1423,6 @@ void HistoryBackend::QueryFilteredURLs(
Add(delta_time),
base::LinearHistogram::FactoryGet("NewTabPage.SuggestedSitesLoadTime",
1, 1000, 100, base::Histogram::kUmaTargetedHistogramFlag));
-
- request->ForwardResult(request->handle(), result);
}
void HistoryBackend::GetRedirectsFromSpecificVisit(

Powered by Google App Engine
This is Rietveld 408576698