Port HistoryService::QueryFilteredURLs to CancelableRequestTracker

Port HistoryService::QueryFilteredURLs to CancelableRequestTracker

The callback no longer receive a HistoryService::Handle and receive
the history::FilteredURLList via a pointer instead of a reference.

Simplify HistoryBackend unit tests to directly call QueryFilteredURLs
and remove the HistoryBackendCancelableRequest class that is no longer
used.

Remove some obsolete code found along the way.

BUG=371818
TBR=jhawkins

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281041

[sdefresne, 2014-06-25 13:56:14]

Please take a look.

[sdefresne, 2014-06-25 13:58:11]

TBR-ing OWNERS of affected client code

TBR=jochen for //chrome/browser/ui OWNERS

[jochen (gone - plz use gerrit), 2014-06-25 13:59:45]

On 2014/06/25 at 13:58:11, sdefresne wrote:
> TBR-ing OWNERS of affected client code
> 
> TBR=jochen for //chrome/browser/ui OWNERS

can you please TBR an owner of c/b/ui/webui/ntp so the owners of the code
actually get to see this?

[sdefresne, 2014-06-25 14:19:25]

TBR-ing OWNERS of affected client code (-jochen, +dbeam)

TBR=dbeam for //chrome/browser/ui/webui/ntp

[sdefresne, 2014-06-25 14:23:49]

+haaawk as the method HistoryService::QueryFilteredURLs is used by clank icing
code (note that this CL is dependent on most of my other CLs refactoring
HistoryService, so it will probably not apply without applying the others).

Dependents CLs (in order):
https://codereview.chromium.org/349153006
https://codereview.chromium.org/351553004
https://codereview.chromium.org/336633004
https://codereview.chromium.org/352623002

[Dan Beam, 2014-06-26 03:47:33]

lgtm

https://chromiumcodereview.appspot.com/351053003/diff/1/chrome/browser/ui/web...
File chrome/browser/ui/webui/ntp/suggestions_source_top_sites.cc (right):

https://chromiumcodereview.appspot.com/351053003/diff/1/chrome/browser/ui/web...
chrome/browser/ui/webui/ntp/suggestions_source_top_sites.cc:96: const
history::FilteredURL& suggested_url = *iter;
nit: revert this hunk, data[i] -> (*data)[i]

[droger, 2014-06-26 09:12:35]

lgtm

[sdefresne, 2014-06-28 07:59:47]

https://codereview.chromium.org/351053003/diff/1/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/suggestions_source_top_sites.cc (right):

https://codereview.chromium.org/351053003/diff/1/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/suggestions_source_top_sites.cc:96: const
history::FilteredURL& suggested_url = *iter;
On 2014/06/26 03:47:33, Dan Beam wrote:
> nit: revert this hunk, data[i] -> (*data)[i]

Done.

[sdefresne, 2014-07-02 13:27:41]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2014-07-02 13:28:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sdefresne@chromium.org/351053003/620001

[commit-bot: I haz the power, 2014-07-02 15:48:27]

Change committed as 281041