Linux sandbox: add test to ensure that pread64 can be forwarded.

Linux sandbox: add test to ensure that pread64 can be forwarded.

Make sure that the pread64() system call can be forwarded from
seccomp-bpf trap handlers.

BUG=388978
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280262

[jln (very slow on Chromium), 2014-06-26 02:21:21]

Matthew: PTAL!

https://chromiumcodereview.appspot.com/348853006/diff/1/sandbox/linux/tests/s...
File sandbox/linux/tests/scoped_temporary_file.cc (right):

https://chromiumcodereview.appspot.com/348853006/diff/1/sandbox/linux/tests/s...
sandbox/linux/tests/scoped_temporary_file.cc:17:
ScopedTemporaryFile::ScopedTemporaryFile() : fd_(-1) {
Just moving old code.

https://chromiumcodereview.appspot.com/348853006/diff/1/sandbox/linux/tests/s...
File sandbox/linux/tests/scoped_temporary_file.h (right):

https://chromiumcodereview.appspot.com/348853006/diff/1/sandbox/linux/tests/s...
sandbox/linux/tests/scoped_temporary_file.h:14: class ScopedTemporaryFile {
This class is being moved (from broker_process_unittests.cc).

https://chromiumcodereview.appspot.com/348853006/diff/1/sandbox/linux/tests/s...
File sandbox/linux/tests/scoped_temporary_file_unittest.cc (right):

https://chromiumcodereview.appspot.com/348853006/diff/1/sandbox/linux/tests/s...
sandbox/linux/tests/scoped_temporary_file_unittest.cc:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
This file is new.

[mdempsky, 2014-06-27 00:37:24]

lgtm

https://codereview.chromium.org/348853006/diff/60001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc (right):

https://codereview.chromium.org/348853006/diff/60001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc:2137: const uint64_t
kLargeOffset = (static_cast<uint64_t>(1) << 32) | 0xBEEF;
Might also be worth testing an offset in [2^31, 2^32), in case there are any
sign extension bugs?

[jln (very slow on Chromium), 2014-06-27 01:25:14]

https://codereview.chromium.org/348853006/diff/60001/sandbox/linux/seccomp-bp...
File sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc (right):

https://codereview.chromium.org/348853006/diff/60001/sandbox/linux/seccomp-bp...
sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc:2137: const uint64_t
kLargeOffset = (static_cast<uint64_t>(1) << 32) | 0xBEEF;
On 2014/06/27 00:37:24, mdempsky wrote:
> Might also be worth testing an offset in [2^31, 2^32), in case there are any
> sign extension bugs?

Great point! I'll land as-is because of a time constrain but I added this as a
follow-up in https://code.google.com/p/chromium/issues/detail?id=388978#c2

[jln (very slow on Chromium), 2014-06-27 01:25:20]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-06-27 01:29:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/348853006/60001

[commit-bot: I haz the power, 2014-06-27 05:36:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  mac_gpu_retina_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_tr...)

[jln (very slow on Chromium), 2014-06-27 06:50:52]

The CQ bit was unchecked by jln@chromium.org

[jln (very slow on Chromium), 2014-06-27 06:50:57]

The CQ bit was checked by jln@chromium.org

[commit-bot: I haz the power, 2014-06-27 06:51:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jln@chromium.org/348853006/60001

[commit-bot: I haz the power, 2014-06-27 07:51:41]

Change committed as 280262