Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 33993002: Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart lo… (Closed)

Created:
7 years, 2 months ago by Jacob
Modified:
7 years, 2 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Companion to https://codereview.chromium.org/33973002 Generate correct source locations for Dart log messages. BUG= R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28976

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M tools/dom/scripts/systemnative.py View 3 chunks +3 lines, -6 lines 1 comment Download
M tools/dom/src/native_DOMImplementation.dart View 1 chunk +9 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Jacob
https://codereview.chromium.org/33993002/diff/1/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (left): https://codereview.chromium.org/33993002/diff/1/tools/dom/scripts/systemnative.py#oldcode919 tools/dom/scripts/systemnative.py:919: ' if (!scriptCallStack->size())\n' it was a bug we ever ...
7 years, 2 months ago (2013-10-21 23:22:31 UTC) #1
Jacob
7 years, 2 months ago (2013-10-22 00:01:52 UTC) #2
vsm
lgtm https://chromiumcodereview.appspot.com/33993002/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/33993002/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode84 tools/dom/src/native_DOMImplementation.dart:84: // Throwing an exception is the only way ...
7 years, 2 months ago (2013-10-22 00:32:59 UTC) #3
Jacob
https://chromiumcodereview.appspot.com/33993002/diff/1/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://chromiumcodereview.appspot.com/33993002/diff/1/tools/dom/src/native_DOMImplementation.dart#newcode84 tools/dom/src/native_DOMImplementation.dart:84: // Throwing an exception is the only way to ...
7 years, 2 months ago (2013-10-22 00:45:37 UTC) #4
Jacob
7 years, 2 months ago (2013-10-22 00:46:34 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r28976 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698