Use suggested filename for "Save Link As"

chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

Index: chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
index f2958f09b583f1fd99382fc2e939e6e4ebe8bd8f..18b764f4feb6ec1bd94c2dc2083386c7719f8952 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc
@@ -229,6 +229,40 @@ IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, OpenIncognitoNoneReferrer) {
   ASSERT_EQ(kEmptyReferrer, page_referrer);
 }
 
+// Check filename on clicking "Save Link As" via a "real" context menu.
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, SuggestedFileName) {
+  // Register observers
+  ContextMenuNotificationObserver menu_observer(IDC_CONTENT_CONTEXT_SAVELINKAS);

[lazyboy, 2014/06/20 17:23:31]

Using ContextMenuNotificationObserver would result in
RVContextMenu::ExecuteCommand to be called which would initiate the download.
You can avoid the download by creating a similar but different
NotificationObserver, that would look for
NOTIFICATION_RENDER_VIEW_CONTEXT_MENU_SHOWN and PostTask a
RenderViewContextMenu::Cancel() and read the params() from the
RenderViewContextMenu*. Then you just verify whether params().suggested_filename
is the right one.

[Nikhil, 2014/06/20 19:37:51]

I tried similar approach earlier by modifying existing
ContextMenuNotificationObserver. One problem that I faced was I still needed
"Wait" mechanism for context menu to get created after mouse event. But I think
I can manage it somehow and remove observer for NOTIFICATION_DOWNLOAD_INITIATED.

I'll try to prepare a patch for this.

On 2014/06/20 17:23:31, lazyboy wrote:

[lazyboy, 2014/06/20 19:50:56]

The notification observer in that class should accomplish exactly that, i.e.
"Wait". The notification is fired once the menu is shown after the event.
 But I think
Sure, if you can remove the actual download from the test, that should be good
enough.

[Nikhil, 2014/06/23 08:02:35]

Modified existing ContextMenuNotificationObserver to consider
IDC_CONTENT_CONTEXT_SAVELINKAS and avoid actual download while executing
command. I had to introduce "WaitForMenu()" because test case won't wait even
though notification observer is waiting to be notified for
NOTIFICATION_RENDER_VIEW_CONTEXT_MENU_SHOWN. 

Please see if this approach looks okay. I verified ContextMenuBrowserTest tests
and all passed.

On 2014/06/20 19:50:56, lazyboy wrote:

+  content::WindowedNotificationObserver download_observer(
+      chrome::NOTIFICATION_DOWNLOAD_INITIATED,
+      content::NotificationService::AllSources());
+
+  // Go to a page with a link having download attribute
+  const std::string kSuggestedFilename("test_filename.png");
+  ui_test_utils::NavigateToURL(
+      browser(),
+      GURL("data:text/html,<a href='about:blank' download='" +
+           kSuggestedFilename + "'>link</a>"));
+
+  // Open a context menu.
+  blink::WebMouseEvent mouse_event;
+  mouse_event.type = blink::WebInputEvent::MouseDown;
+  mouse_event.button = blink::WebMouseEvent::ButtonRight;
+  mouse_event.x = 15;
+  mouse_event.y = 15;
+  content::WebContents* tab =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);
+  mouse_event.type = blink::WebInputEvent::MouseUp;
+  tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);
+
+  // Wait for context menu to get created and download to initiate
+  download_observer.Wait();
+
+  base::string16 suggested_filename = menu_observer.GetSuggestedFilename();
+  ASSERT_EQ(kSuggestedFilename, base::UTF16ToUTF8(suggested_filename).c_str());
+}
+
 // Ensure that View Page Info won't crash if there is no visible entry.
 // See http://crbug.com/370863.
 IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoWithNoEntry) {