Use suggested filename for "Save Link As"

chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
@@ skipping 211 matching lines @@
 
   // Verify that the referrer on the page matches |kEmptyReferrer|.
   std::string page_referrer;
   ASSERT_TRUE(content::ExecuteScriptAndExtractString(
       tab,
       "window.domAutomationController.send(window.document.referrer);",
       &page_referrer));
   ASSERT_EQ(kEmptyReferrer, page_referrer);
 }
 
+// Check filename on clicking "Save Link As" via a "real" context menu.
+IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, SuggestedFileName) {
+  // Register observers
+  ContextMenuNotificationObserver menu_observer(IDC_CONTENT_CONTEXT_SAVELINKAS);

[lazyboy, 2014/06/20 17:23:31]

Using ContextMenuNotificationObserver would result in
RVContextMenu::ExecuteCommand to be called which would initiate the download.
You can avoid the download by creating a similar but different
NotificationObserver, that would look for
NOTIFICATION_RENDER_VIEW_CONTEXT_MENU_SHOWN and PostTask a
RenderViewContextMenu::Cancel() and read the params() from the
RenderViewContextMenu*. Then you just verify whether params().suggested_filename
is the right one.

[Nikhil, 2014/06/20 19:37:51]

I tried similar approach earlier by modifying existing
ContextMenuNotificationObserver. One problem that I faced was I still needed
"Wait" mechanism for context menu to get created after mouse event. But I think
I can manage it somehow and remove observer for NOTIFICATION_DOWNLOAD_INITIATED.

I'll try to prepare a patch for this.

On 2014/06/20 17:23:31, lazyboy wrote:

[lazyboy, 2014/06/20 19:50:56]

The notification observer in that class should accomplish exactly that, i.e.
"Wait". The notification is fired once the menu is shown after the event.
 But I think
Sure, if you can remove the actual download from the test, that should be good
enough.

[Nikhil, 2014/06/23 08:02:35]

Modified existing ContextMenuNotificationObserver to consider
IDC_CONTENT_CONTEXT_SAVELINKAS and avoid actual download while executing
command. I had to introduce "WaitForMenu()" because test case won't wait even
though notification observer is waiting to be notified for
NOTIFICATION_RENDER_VIEW_CONTEXT_MENU_SHOWN. 

Please see if this approach looks okay. I verified ContextMenuBrowserTest tests
and all passed.

On 2014/06/20 19:50:56, lazyboy wrote:

+  content::WindowedNotificationObserver download_observer(
+      chrome::NOTIFICATION_DOWNLOAD_INITIATED,
+      content::NotificationService::AllSources());
+
+  // Go to a page with a link having download attribute
+  const std::string kSuggestedFilename("test_filename.png");
+  ui_test_utils::NavigateToURL(
+      browser(),
+      GURL("data:text/html,<a href='about:blank' download='" +
+           kSuggestedFilename + "'>link</a>"));
+
+  // Open a context menu.
+  blink::WebMouseEvent mouse_event;
+  mouse_event.type = blink::WebInputEvent::MouseDown;
+  mouse_event.button = blink::WebMouseEvent::ButtonRight;
+  mouse_event.x = 15;
+  mouse_event.y = 15;
+  content::WebContents* tab =
+      browser()->tab_strip_model()->GetActiveWebContents();
+  tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);
+  mouse_event.type = blink::WebInputEvent::MouseUp;
+  tab->GetRenderViewHost()->ForwardMouseEvent(mouse_event);
+
+  // Wait for context menu to get created and download to initiate
+  download_observer.Wait();
+
+  base::string16 suggested_filename = menu_observer.GetSuggestedFilename();
+  ASSERT_EQ(kSuggestedFilename, base::UTF16ToUTF8(suggested_filename).c_str());
+}
+
 // Ensure that View Page Info won't crash if there is no visible entry.
 // See http://crbug.com/370863.
 IN_PROC_BROWSER_TEST_F(ContextMenuBrowserTest, ViewPageInfoWithNoEntry) {
   // Create a new tab with no committed entry.
   ui_test_utils::WindowedTabAddedNotificationObserver tab_observer(
       content::NotificationService::AllSources());
   ASSERT_TRUE(content::ExecuteScript(
       browser()->tab_strip_model()->GetActiveWebContents(), "window.open();"));
   tab_observer.Wait();
   content::WebContents* tab = tab_observer.GetTab();
   EXPECT_FALSE(tab->GetController().GetLastCommittedEntry());
   EXPECT_FALSE(tab->GetController().GetVisibleEntry());
 
   // Create a context menu.
   content::ContextMenuParams context_menu_params;
   TestRenderViewContextMenu menu(tab->GetMainFrame(), context_menu_params);
   menu.Init();
 
   // The item shouldn't be enabled in the menu.
   EXPECT_FALSE(menu.IsCommandIdEnabled(IDC_CONTENT_CONTEXT_VIEWPAGEINFO));
 
   // Ensure that viewing page info doesn't crash even if you can get to it.
   menu.ExecuteCommand(IDC_CONTENT_CONTEXT_VIEWPAGEINFO, 0);
 }
 
 }  // namespace