dump-info additionally dumps a json info file

dump-info additionally dumps a json info file

In addition to dumping the .info.html file, the dump-info flag
now also dumps a .info.json file that contains the same
information as the .info.html file.  This is the first step
in replacing the .info.html file with a dynamic dump viewer.

Currently both the .info.json file and the .info.html file are
created, however the plan is to remove the .info.html file once
a suitable viewer for the .info.json file has been created.

BUG=
R=floitsch@google.com, sigurdm@google.com, sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=37612

[Ty Overby, 2014-06-20 19:36:47]

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart2js.dart:426: uri =
out.resolve('$outName.$extension');
This could probably be grouped into the case from above.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:148: props['children']
= this.contents.map((c) => c.toJson(programInfo)).toList();
Line over 80 chars.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:299: Map<String,
dynamic> json = {};
Either have this variable be called `props` or have the other ones called
`json`.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:604:
buffer.writeln(JSON.encode(entire));
The performance of this could probably be improved by using Sinks.

[Ty Overby, 2014-06-20 19:47:28]

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dart2js.dart:426: uri =
out.resolve('$outName.$extension');
On 2014/06/20 19:36:47, Ty Overby wrote:
> This could probably be grouped into the case from above.

Done.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:148: props['children']
= this.contents.map((c) => c.toJson(programInfo)).toList();
On 2014/06/20 19:36:47, Ty Overby wrote:
> Line over 80 chars.

Done.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:299: Map<String,
dynamic> json = {};
On 2014/06/20 19:36:47, Ty Overby wrote:
> Either have this variable be called `props` or have the other ones called
> `json`.

Done.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:604:
buffer.writeln(JSON.encode(entire));
On 2014/06/20 19:36:47, Ty Overby wrote:
> The performance of this could probably be improved by using Sinks.

Done.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:604:
buffer.writeln(JSON.encode(entire));
On 2014/06/20 19:36:47, Ty Overby wrote:
> The performance of this could probably be improved by using Sinks.

Done.

[sra1, 2014-06-20 19:49:27]

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:222: Map<String,
dynamic> props = {};
You can use the literal syntax to add the always-included members:

Map<String, dynamic> props = <String, dynamic>{
  'kind': 'code',
  'description': description,
   ...
}

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:299: Map<String,
dynamic> json = {};
On 2014/06/20 19:36:47, Ty Overby wrote:
> Either have this variable be called `props` or have the other ones called
> `json`.

I think `json`.

[Ty Overby, 2014-06-20 19:59:13]

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:222: Map<String,
dynamic> props = {};
On 2014/06/20 19:49:27, sra1 wrote:
> You can use the literal syntax to add the always-included members:
> 
> Map<String, dynamic> props = <String, dynamic>{
>   'kind': 'code',
>   'description': description,
>    ...
> }

Done.

https://codereview.chromium.org/336003003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/dump_info.dart:299: Map<String,
dynamic> json = {};
On 2014/06/20 19:49:27, sra1 wrote:
> On 2014/06/20 19:36:47, Ty Overby wrote:
> > Either have this variable be called `props` or have the other ones called
> > `json`.
> 
> I think `json`.

`json` is what I went with.

[sra1, 2014-06-20 22:16:35]

LGTM with the suggestions.

Let Florian review before committing.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:146:
json['size_percent'] =
inconstistent name - use 'sizePercent' to match one below.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:231: 'sizePercent':
(100 * generatedCode.length / programInfo.size).toStringAsFixed(3) + "%"
Long line (should be <= 80 chars)

Maybe abstract out the formatting since it looks just like the other one.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:255: 'kind':
"inferred",
Use single quotes unless there are embedded single quotes.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:603: Map entire = {};
Add types.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:604: entire['program']
= info.toJson();
maybe include this in the literal.

[floitsch, 2014-06-20 22:27:57]

LGTM.

I added Sigurd as reviewer, but you don't need to wait for his review. If he has
suggestions we can do a follow-up CL.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:91: Map<String,
dynamic> toJson(ProgramInfo programInfo);
I would prefer not to pollute the InfoNode with a toJson function.

I can live with it, but what I would do:
create a visitor for the nodes, and pass a serializer-function to the
json-encoder.

That said: we already have emitHtml all over the place... So a toJson doesn't
really change much anymore. Ideally both should be independent of the Nodes.

[Ty Overby, 2014-06-20 22:58:04]

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
File sdk/lib/_internal/compiler/implementation/dump_info.dart (right):

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:146:
json['size_percent'] =
On 2014/06/20 22:16:34, sra1 wrote:
> inconstistent name - use 'sizePercent' to match one below.

Done.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:231: 'sizePercent':
(100 * generatedCode.length / programInfo.size).toStringAsFixed(3) + "%"
On 2014/06/20 22:16:34, sra1 wrote:
> Long line (should be <= 80 chars)
> 
> Maybe abstract out the formatting since it looks just like the other one.

Done.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:255: 'kind':
"inferred",
On 2014/06/20 22:16:34, sra1 wrote:
> Use single quotes unless there are embedded single quotes.

Done.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:603: Map entire = {};
On 2014/06/20 22:16:34, sra1 wrote:
> Add types.

Done.

https://chromiumcodereview.appspot.com/336003003/diff/40001/sdk/lib/_internal...
sdk/lib/_internal/compiler/implementation/dump_info.dart:604: entire['program']
= info.toJson();
On 2014/06/20 22:16:34, sra1 wrote:
> maybe include this in the literal.

Done.

[Ty Overby, 2014-06-20 23:08:17]

The CQ bit was checked by tyoverby@chromium.org

[commit-bot: I haz the power, 2014-06-20 23:10:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-20 23:10:18]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[sigurdm, 2014-06-23 07:02:33]

LGTM

[Ty Overby, 2014-06-23 18:13:14]

Committed patchset #5 manually as r37612 (presubmit successful).

[sigurdm, 2014-06-24 06:23:21]

I now remembered that you should probably also update the help message in --help
--verbose to reflect the new behavior.
It is in the function verboseHelp in the file implementation/dart2js.dart