Network connectivity errors handling (incl. CP) for enrollment flow

chrome/browser/chromeos/login/ui/webui_login_view.cc

Index: chrome/browser/chromeos/login/ui/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc
index cdadcf225f7a530e33cee2b76bdc792289c5616d..91c7a8776b01a14df0a4a4a15e32a655403a89b2 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc
@@ -311,6 +311,15 @@ void WebUILoginView::SetUIEnabled(bool enabled) {
   ash::Shell::GetInstance()->GetPrimarySystemTray()->SetEnabled(enabled);
 }
 
+void WebUILoginView::AddFrameObserver(FrameObserver* frame_observer) {
+  if (frame_observer && !frame_observer_list_.HasObserver(frame_observer))

[Denis Kuznetsov (DE-MUC), 2014/06/23 17:42:01]

Does it make sense to have NULL frame_observer?
What should happen on RemoveObserver if it was NULL initially?
What if we double-add it and then double-remove it?

[Roman Sorokin (ftl), 2014/06/25 16:30:12]

I copied this code from another function AddObserver which is virtual. This
function is not virtual and being used in one place so I guess I could remove
test on NULL.
Nothing
ObserverList does not allow double-add observers. It will log error and won't
add observer second time.

+    frame_observer_list_.AddObserver(frame_observer);
+}
+
+void WebUILoginView::RemoveFrameObserver(FrameObserver* frame_observer) {
+  frame_observer_list_.RemoveObserver(frame_observer);
+}
+
 // WebUILoginView protected: ---------------------------------------------------
 
 void WebUILoginView::Layout() {
@@ -430,6 +439,8 @@ void WebUILoginView::DidFailProvisionalLoad(
     int error_code,
     const base::string16& error_description,
     content::RenderViewHost* render_view_host) {
+  FOR_EACH_OBSERVER(
+      FrameObserver, frame_observer_list_, onFrameError(frame_unique_name));
   if (frame_unique_name != base::UTF8ToUTF16("gaia-frame"))
     return;