Network connectivity errors handling (incl. CP) for enrollment flow

chrome/browser/chromeos/login/ui/webui_login_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 
 #include "ash/shell.h"
 #include "ash/system/tray/system_tray.h"
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 293 matching lines @@
       tray->GetWidget()->Hide();
     }
   }
 }
 
 void WebUILoginView::SetUIEnabled(bool enabled) {
   forward_keyboard_event_ = enabled;
   ash::Shell::GetInstance()->GetPrimarySystemTray()->SetEnabled(enabled);
 }
 
+void WebUILoginView::AddFrameObserver(FrameObserver* frame_observer) {
+  if (frame_observer && !frame_observer_list_.HasObserver(frame_observer))

[Denis Kuznetsov (DE-MUC), 2014/06/23 17:42:01]

Does it make sense to have NULL frame_observer?
What should happen on RemoveObserver if it was NULL initially?
What if we double-add it and then double-remove it?

[Roman Sorokin (ftl), 2014/06/25 16:30:12]

I copied this code from another function AddObserver which is virtual. This
function is not virtual and being used in one place so I guess I could remove
test on NULL.
Nothing
ObserverList does not allow double-add observers. It will log error and won't
add observer second time.

+    frame_observer_list_.AddObserver(frame_observer);
+}
+
+void WebUILoginView::RemoveFrameObserver(FrameObserver* frame_observer) {
+  frame_observer_list_.RemoveObserver(frame_observer);
+}
+
 // WebUILoginView protected: ---------------------------------------------------
 
 void WebUILoginView::Layout() {
   DCHECK(webui_login_);
   webui_login_->SetBoundsRect(bounds());
 
   FOR_EACH_OBSERVER(web_modal::ModalDialogHostObserver,
                     observer_list_,
                     OnPositionRequiresUpdate());
 }
@@ skipping 99 matching lines @@
 }
 
 void WebUILoginView::DidFailProvisionalLoad(
     int64 frame_id,
     const base::string16& frame_unique_name,
     bool is_main_frame,
     const GURL& validated_url,
     int error_code,
     const base::string16& error_description,
     content::RenderViewHost* render_view_host) {
+  FOR_EACH_OBSERVER(
+      FrameObserver, frame_observer_list_, onFrameError(frame_unique_name));
   if (frame_unique_name != base::UTF8ToUTF16("gaia-frame"))
     return;
 
   GetWebUI()->CallJavascriptFunction("login.GaiaSigninScreen.onFrameError",
                                      base::FundamentalValue(-error_code),
                                      base::StringValue(validated_url.spec()));
 }
 
 void WebUILoginView::OnLoginPromptVisible() {
   // If we're hidden than will generate this signal once we're shown.
@@ skipping 12 matching lines @@
   webui_visible_ = true;
 }
 
 void WebUILoginView::ReturnFocus(bool reverse) {
   // Return the focus to the web contents.
   webui_login_->web_contents()->FocusThroughTabTraversal(reverse);
   GetWidget()->Activate();
 }
 
 }  // namespace chromeos