Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 331133004: skia: Replaced GetScriptResourceName() with GetScriptOrigin().ResourceName() (Closed)

Created:
6 years, 6 months ago by kozyatinskiy1
Modified:
6 years, 5 months ago
Reviewers:
vsevik, reed2, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master1
Visibility:
Public.

Description

Replaced deprecated v8::Message::GetScriptResourceName() with v8::Message::GetScriptOrigin().ResourceName(). More details about v8::Message::GetScriptOrigin(): https://codereview.chromium.org/265593002/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M experimental/SkV8Example/Global.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
kozyatinskiy1
The patch depends on https://codereview.chromium.org/265593002/ - v8::Message::GetScripOrigin()
6 years, 6 months ago (2014-06-16 09:20:26 UTC) #1
vsevik
lgtm
6 years, 6 months ago (2014-06-16 11:19:02 UTC) #2
kozyatinskiy1
Mike, Could you please make review?
6 years, 6 months ago (2014-06-16 11:40:23 UTC) #3
reed1
lgtm
6 years, 6 months ago (2014-06-16 13:08:47 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 13:13:32 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 6 months ago (2014-06-16 13:13:32 UTC) #6
jcgregorio
Thanks for the patch! Was this just a quick fix you happened to notice, or ...
6 years, 6 months ago (2014-06-16 13:17:34 UTC) #7
vsevik
This patch is just updating skia to use the new API added in https://codereview.chromium.org/265593002/ Please ...
6 years, 6 months ago (2014-06-16 13:19:27 UTC) #8
vsevik
reed@, Could you please land this now that V8 has updated in chromium?
6 years, 6 months ago (2014-06-25 06:32:46 UTC) #9
vsevik
reed@: friendly ping
6 years, 5 months ago (2014-06-30 11:34:11 UTC) #10
reed1
On 2014/06/30 11:34:11, vsevik wrote: > reed@: friendly ping landed manually
6 years, 5 months ago (2014-07-15 15:14:50 UTC) #11
vsevik
6 years, 5 months ago (2014-07-15 15:22:48 UTC) #12
Thanks!

Powered by Google App Engine
This is Rietveld 408576698