experimental/SkV8Example/Global.cpp - Issue 331133004: skia: Replaced GetScriptResourceName() with GetScriptOrigin().ResourceName()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: experimental/SkV8Example/Global.cpp

Issue 331133004: skia: Replaced GetScriptResourceName() with GetScriptOrigin().ResourceName() (Closed) Base URL: https://chromium.googlesource.com/skia.git@master1

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: experimental/SkV8Example/Global.cpp

diff --git a/experimental/SkV8Example/Global.cpp b/experimental/SkV8Example/Global.cpp

index e8ad318d40268c8cd3346d2e5f21d0b9c06649ca..4bbdb7bf45e349a27d2f4b4e1a5b7fee0dac1c73 100644

--- a/experimental/SkV8Example/Global.cpp

+++ b/experimental/SkV8Example/Global.cpp

@@ -41,7 +41,7 @@ void Global::reportException(TryCatch* tryCatch) {

fprintf(stderr, "%s\n", exceptionString);

} else {

// Print (filename):(line number): (message).

- String::Utf8Value filename(message->GetScriptResourceName());

+ String::Utf8Value filename(message->GetScriptOrigin().ResourceName());

const char* filenameString = to_cstring(filename);

int linenum = message->GetLineNumber();

fprintf(stderr,

« no previous file with comments | « no previous file | no next file » | no next file with comments »