chrome/browser/apps/web_view_browsertest.cc - Issue 316173003: Re-enable WebViewTest.Shim_TestDestroyOnEventListener.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 316173003: Re-enable WebViewTest.Shim_TestDestroyOnEventListener. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove code for repeating test 200 times, ready for review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index 650d2b5dbe3dcf53c8272709fcedb31748f75f30..af577fb32d06827c5277a3df53007276642f5f6e 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -912,12 +912,11 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestLoadProgressEvent) {

TestHelper("testLoadProgressEvent", "web_view/shim", NO_TEST_SERVER);

}

-// WebViewTest.Shim_TestDestroyOnEventListener is flaky, so disable it.

-// http://crbug.com/255106

-IN_PROC_BROWSER_TEST_F(WebViewTest, DISABLED_Shim_TestDestroyOnEventListener) {

+IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestDestroyOnEventListener) {

TestHelper("testDestroyOnEventListener", "web_view/shim", NO_TEST_SERVER);

}

wjmaclean 2014/06/05 20:37:15 nit: Why the extra blank line?

lazyboy 2014/06/05 20:50:24 Leftover from debugging, fixed. Done.

IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestCannotMutateEventName) {

TestHelper("testCannotMutateEventName", "web_view/shim", NO_TEST_SERVER);

}

« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | no next file with comments »