Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 316173003: Re-enable WebViewTest.Shim_TestDestroyOnEventListener. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove code for repeating test 200 times, ready for review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/ui/native_app_window.h" 5 #include "apps/ui/native_app_window.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/apps/app_browsertest_util.h" 10 #include "chrome/browser/apps/app_browsertest_util.h"
(...skipping 894 matching lines...) Expand 10 before | Expand all | Expand 10 after
905 // WebViewTest.Shim_TestOnEventProperty is flaky, so disable it. 905 // WebViewTest.Shim_TestOnEventProperty is flaky, so disable it.
906 // http://crbug.com/359832. 906 // http://crbug.com/359832.
907 IN_PROC_BROWSER_TEST_F(WebViewTest, DISABLED_Shim_TestOnEventProperty) { 907 IN_PROC_BROWSER_TEST_F(WebViewTest, DISABLED_Shim_TestOnEventProperty) {
908 TestHelper("testOnEventProperties", "web_view/shim", NO_TEST_SERVER); 908 TestHelper("testOnEventProperties", "web_view/shim", NO_TEST_SERVER);
909 } 909 }
910 910
911 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestLoadProgressEvent) { 911 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestLoadProgressEvent) {
912 TestHelper("testLoadProgressEvent", "web_view/shim", NO_TEST_SERVER); 912 TestHelper("testLoadProgressEvent", "web_view/shim", NO_TEST_SERVER);
913 } 913 }
914 914
915 // WebViewTest.Shim_TestDestroyOnEventListener is flaky, so disable it. 915 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestDestroyOnEventListener) {
916 // http://crbug.com/255106
917 IN_PROC_BROWSER_TEST_F(WebViewTest, DISABLED_Shim_TestDestroyOnEventListener) {
918 TestHelper("testDestroyOnEventListener", "web_view/shim", NO_TEST_SERVER); 916 TestHelper("testDestroyOnEventListener", "web_view/shim", NO_TEST_SERVER);
919 } 917 }
920 918
919
wjmaclean 2014/06/05 20:37:15 nit: Why the extra blank line?
lazyboy 2014/06/05 20:50:24 Leftover from debugging, fixed. Done.
921 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestCannotMutateEventName) { 920 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestCannotMutateEventName) {
922 TestHelper("testCannotMutateEventName", "web_view/shim", NO_TEST_SERVER); 921 TestHelper("testCannotMutateEventName", "web_view/shim", NO_TEST_SERVER);
923 } 922 }
924 923
925 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestPartitionRaisesException) { 924 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestPartitionRaisesException) {
926 TestHelper("testPartitionRaisesException", "web_view/shim", NO_TEST_SERVER); 925 TestHelper("testPartitionRaisesException", "web_view/shim", NO_TEST_SERVER);
927 } 926 }
928 927
929 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestExecuteScriptFail) { 928 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestExecuteScriptFail) {
930 #if defined(OS_WIN) 929 #if defined(OS_WIN)
(...skipping 1228 matching lines...) Expand 10 before | Expand all | Expand 10 after
2159 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestFindAPI_findupdate) { 2158 IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestFindAPI_findupdate) {
2160 TestHelper("testFindAPI_findupdate", "web_view/shim", NO_TEST_SERVER); 2159 TestHelper("testFindAPI_findupdate", "web_view/shim", NO_TEST_SERVER);
2161 } 2160 }
2162 2161
2163 // <webview> screenshot capture fails with ubercomp. 2162 // <webview> screenshot capture fails with ubercomp.
2164 // See http://crbug.com/327035. 2163 // See http://crbug.com/327035.
2165 IN_PROC_BROWSER_TEST_F(WebViewCaptureTest, 2164 IN_PROC_BROWSER_TEST_F(WebViewCaptureTest,
2166 DISABLED_Shim_ScreenshotCapture) { 2165 DISABLED_Shim_ScreenshotCapture) {
2167 TestHelper("testScreenshotCapture", "web_view/shim", NO_TEST_SERVER); 2166 TestHelper("testScreenshotCapture", "web_view/shim", NO_TEST_SERVER);
2168 } 2167 }
OLDNEW
« no previous file with comments | « no previous file | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698