Issue 316173003: Re-enable WebViewTest.Shim_TestDestroyOnEventListener.

Issue 316173003: Re-enable WebViewTest.Shim_TestDestroyOnEventListener. (Closed)

Created:
6 years, 6 months ago by lazyboy

Modified:
6 years, 6 months ago

Reviewers:
wjmaclean

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Re-enable WebViewTest.Shim_TestDestroyOnEventListener. There seems to be an error on counting number of loadcommits. Although this doesn't explain why the test would have been timing out flakily before. I've checked running the test in each major platform 200 times: win/linux/mac/chromeos, seems to have no flakiness at all (see trybot results on patchset #1). I'm just re-enabling them. BUG=255106 Test=Internal test only change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275288

Patch Set 1 #

Patch Set 2 : remove code for repeating test 200 times, ready for review #

Total comments: 2

Patch Set 3 : address nit from James #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	chrome/browser/apps/web_view_browsertest.cc	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download
	M	chrome/test/data/extensions/platform_apps/web_view/shim/main.js	View		2 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

wjmaclean

lgtm, with one nit. https://chromiumcodereview.appspot.com/316173003/diff/20001/chrome/browser/apps/web_view_browsertest.cc File chrome/browser/apps/web_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/316173003/diff/20001/chrome/browser/apps/web_view_browsertest.cc#newcode919 chrome/browser/apps/web_view_browsertest.cc:919: nit: Why the extra blank ...

6 years, 6 months ago (2014-06-05 20:37:15 UTC) #2

lazyboy

https://chromiumcodereview.appspot.com/316173003/diff/20001/chrome/browser/apps/web_view_browsertest.cc File chrome/browser/apps/web_view_browsertest.cc (right): https://chromiumcodereview.appspot.com/316173003/diff/20001/chrome/browser/apps/web_view_browsertest.cc#newcode919 chrome/browser/apps/web_view_browsertest.cc:919: On 2014/06/05 20:37:15, wjmaclean wrote: > nit: Why the ...

6 years, 6 months ago (2014-06-05 20:50:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lazyboy@chromium.org/316173003/40001

6 years, 6 months ago (2014-06-05 20:52:22 UTC) #5

Message was sent while issue was closed.

Change committed as 275288

Expand Messages | Collapse Messages