chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/active_tab_unittest.cc ('K') | « chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc ('k') | chrome/browser/extensions/api/hid/hid_api.cc » ('j') | chrome/browser/extensions/api/media_galleries/media_galleries_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

index 1a245c17dbc4d88aa64c1ca7354ec8fcbdae06ed..2bb0177842cf34694785c4491ca496b0f505239e 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc

@@ -195,10 +195,13 @@ IN_PROC_BROWSER_TEST_F(BrowserActionInteractiveTest,

OpenExtensionPopupViaAPI();

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

- ASSERT_FALSE(PermissionsData::HasAPIPermissionForTab(

- service->GetExtensionById(last_loaded_extension_id(), false),

- SessionID::IdForTab(browser()->tab_strip_model()->GetActiveWebContents()),

- APIPermission::kTab));

+ ASSERT_FALSE(

+ PermissionsData::ForExtension(

+ service->GetExtensionById(last_loaded_extension_id(), false))

+ ->HasAPIPermissionForTab(

+ SessionID::IdForTab(

+ browser()->tab_strip_model()->GetActiveWebContents()),

+ APIPermission::kTab));

}

// Test that the extension popup is closed when the browser window is clicked.