chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/active_tab_unittest.cc ('K') | « chrome/browser/extensions/api/cookies/cookies_helpers.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc » ('j') | chrome/browser/extensions/api/media_galleries/media_galleries_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

index 189a441b16891670e90929cd75b85a9440fb4eab..1ac200edd25f227f0c254c031ee843103d2331a2 100644

--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.cc

@@ -344,7 +344,7 @@ bool WebRequestRulesRegistry::HostPermissionsChecker(

const Extension* extension,

const WebRequestActionSet* actions,

std::string* error) {

- if (PermissionsData::HasEffectiveAccessToAllHosts(extension))

+ if (PermissionsData::ForExtension(extension)->HasEffectiveAccessToAllHosts())

return true;

// Without the permission for all URLs, actions with the STRATEGY_DEFAULT