Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(24)

Issue 3016683002: Sort overview chart in histogram-set-table-name-cell. (Closed)

Created:
1 year, 6 months ago by benjhayden
Modified:
1 year, 6 months ago
Reviewers:
eakuefner, shatch
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org, tiborg
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Sort overview chart in histogram-set-table-name-cell. Currently, the overview line chart in the Name column cells is generated from a Map from column title to Histogram. However, Maps are not guaranteed to be in any particular order. This CL adds a generator method to HistogramSetTableRow that yields the column titles and Histograms in the same order as the baseTable's columns. Before: http://i.imgur.com/yHwbhNI.png After: http://i.imgur.com/BFYjKWg.png

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M tracing/tracing/value/ui/histogram_set_table.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_name_cell.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/histogram_set_table_row.html View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (5 generated)
benjhayden
1 year, 6 months ago (2017-09-27 18:09:17 UTC) #6

          

Powered by Google App Engine
This is Rietveld 408576698