Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(27)

Issue 3016673002: Dashboard - Add pinpoint-perf-job-dialog for perf try jobs.

Created:
1 year, 2 months ago by shatch
Modified:
1 year, 2 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Dashboard - Add pinpoint-perf-job-dialog for perf try jobs. Dashboard initiates perf try jobs when you hit "request debug trace" via the chart tooltip. This adds a Pinpoint version of the trace dialog that routes the request to Pinpoint. Basically cloned the trace-form dialog into pinpoint-perf-job-dialog, and changed the internals to communicate with the /pinpoint endpoint. Should look and act exactly the same, with the exception that it will say "Send to Pinpoint". BUG=chromium:768530

Patch Set 1 #

Total comments: 7

Patch Set 2 : Address comments. #

Patch Set 3 : Disable until Pinpoint ready. #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+791 lines, -23 lines) Patch
M dashboard/dashboard/dispatcher.py View 1 chunk +4 lines, -1 line 0 comments Download
M dashboard/dashboard/elements/bisect-button.html View 2 chunks +2 lines, -5 lines 0 comments Download
M dashboard/dashboard/elements/pinpoint-job-dialog.html View 1 chunk +2 lines, -1 line 0 comments Download
A dashboard/dashboard/elements/pinpoint-perf-job-dialog.html View 1 2 3 1 chunk +198 lines, -0 lines 0 comments Download
A dashboard/dashboard/elements/pinpoint-perf-job-dialog-test.html View 1 2 3 1 chunk +164 lines, -0 lines 0 comments Download
M dashboard/dashboard/elements/trace-button.html View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M dashboard/dashboard/pinpoint_request.py View 6 chunks +120 lines, -13 lines 0 comments Download
M dashboard/dashboard/pinpoint_request_test.py View 1 chunk +267 lines, -3 lines 0 comments Download
A dashboard/dashboard/static/pinpoint.html View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (26 generated)
shatch
Demo: https://dev-simonhatch-f3dece92-dot-chromeperf.appspot.com/report?sid=f5a7863b8c755737974a89803a8483b50c8e536a7d18da09885ee551b11a131c&start_rev=494037&end_rev=504321 Just cloned the existing trace-form rather than try to make the code co-exist ...
1 year, 2 months ago (2017-09-27 15:18:40 UTC) #22
sullivan
lgtm https://codereview.chromium.org/3016673002/diff/100001/dashboard/dashboard/elements/pinpoint-perf-job-dialog.html File dashboard/dashboard/elements/pinpoint-perf-job-dialog.html (right): https://codereview.chromium.org/3016673002/diff/100001/dashboard/dashboard/elements/pinpoint-perf-job-dialog.html#newcode41 dashboard/dashboard/elements/pinpoint-perf-job-dialog.html:41: <paper-input type="text" value="[[getBot(test_path)]]" disabled></paper-input> Eventually there needs to ...
1 year, 2 months ago (2017-09-27 19:30:34 UTC) #25
shatch
Also disabled this for now until Pinpoint is ready. https://codereview.chromium.org/3016673002/diff/100001/dashboard/dashboard/elements/pinpoint-perf-job-dialog.html File dashboard/dashboard/elements/pinpoint-perf-job-dialog.html (right): https://codereview.chromium.org/3016673002/diff/100001/dashboard/dashboard/elements/pinpoint-perf-job-dialog.html#newcode41 dashboard/dashboard/elements/pinpoint-perf-job-dialog.html:41: ...
1 year, 2 months ago (2017-09-27 20:41:25 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3016673002/140001
1 year, 2 months ago (2017-09-27 20:41:45 UTC) #29
commit-bot: I haz the power
1 year, 2 months ago (2017-09-27 21:22:20 UTC) #31
Try jobs failed on following builders:
  Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Wi...)

Powered by Google App Engine
This is Rietveld 408576698