Fix Gn untracked headers in webrtc/p2p

Fix Gn untracked headers in webrtc/p2p

BUG=webrtc:7646
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3013063002
Cr-Commit-Position: refs/heads/master@{#19824}

[charujain, 2017-09-14 15:14:40]

Description was changed from

==========
Fix Gn untracked headers in webrtc/p2p

BUG=None
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3013063002
Cr-Commit-Position: refs/heads/master@{#19824}
==========

to

==========
Fix Gn untracked headers in webrtc/p2p

BUG=webrtc:7646
CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal

Review-Url: https://codereview.webrtc.org/3013063002
Cr-Commit-Position: refs/heads/master@{#19824}
==========

[charujain, 2017-09-14 15:31:39]

charujain@webrtc.org changed reviewers:
+ kjellander@google.com, mbonadei@webrtc.org

[charujain, 2017-09-19 08:57:29]

On 2017/09/14 15:31:39, charujain wrote:
> mailto:charujain@webrtc.org changed reviewers:
> + mailto:kjellander@google.com, mailto:mbonadei@webrtc.org

PTAL.

[mbonadei, 2017-09-19 09:04:50]

https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn
File p2p/BUILD.gn (right):

https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn#newcode127
p2p/BUILD.gn:127: "base/transportchannelimpl.h",
I am missing some context here so maybe this is a trivial question.
Why this has been added in this if branch (only when rtc_use_quic is true)?

[kjellander_webrtc, 2017-09-19 16:08:22]

kjellander@webrtc.org changed reviewers:
+ kjellander@webrtc.org
- kjellander@google.com

[kjellander_webrtc, 2017-09-19 16:10:27]

kjellander@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[kjellander_webrtc, 2017-09-19 16:10:29]

+deadbeef@ as OWNER

https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn
File p2p/BUILD.gn (right):

https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn#newcode127
p2p/BUILD.gn:127: "base/transportchannelimpl.h",
On 2017/09/19 09:04:50, mbonadei wrote:
> I am missing some context here so maybe this is a trivial question.
> Why this has been added in this if branch (only when rtc_use_quic is true)?

Seems like it's only included in the code in this section:
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/quic/quictranspor...

Adding Taylor for input on this. Maybe moving the header first is better (e.g.
into p2p/quic)

[charujain, 2017-09-22 11:16:32]

On 2017/09/19 16:10:29, kjellander_webrtc wrote:
> +deadbeef@ as OWNER
> 
> https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn
> File p2p/BUILD.gn (right):
> 
> https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn#newcode127
> p2p/BUILD.gn:127: "base/transportchannelimpl.h",
> On 2017/09/19 09:04:50, mbonadei wrote:
> > I am missing some context here so maybe this is a trivial question.
> > Why this has been added in this if branch (only when rtc_use_quic is true)?
> 
> Seems like it's only included in the code in this section:
>
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/quic/quictranspor...
> 
> Adding Taylor for input on this. Maybe moving the header first is better (e.g.
> into p2p/quic)

Taylor, please let us know if it's fine to move the header.

[Taylor Brandstetter, 2017-09-22 14:09:33]

On 2017/09/22 11:16:32, charujain wrote:
> On 2017/09/19 16:10:29, kjellander_webrtc wrote:
> > +deadbeef@ as OWNER
> > 
> > https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn
> > File p2p/BUILD.gn (right):
> > 
> > https://codereview.webrtc.org/3016513002/diff/20001/p2p/BUILD.gn#newcode127
> > p2p/BUILD.gn:127: "base/transportchannelimpl.h",
> > On 2017/09/19 09:04:50, mbonadei wrote:
> > > I am missing some context here so maybe this is a trivial question.
> > > Why this has been added in this if branch (only when rtc_use_quic is
true)?
> > 
> > Seems like it's only included in the code in this section:
> >
>
https://cs.chromium.org/chromium/src/third_party/webrtc/p2p/quic/quictranspor...
> > 
> > Adding Taylor for input on this. Maybe moving the header first is better
(e.g.
> > into p2p/quic)
> 
> Taylor, please let us know if it's fine to move the header.

Sorry, was at an offsite this week and haven't had time to respond to emails.
Anyway, the quic code in webrtc is effectively dead, since we decided to work on
quic/webrtc integration internally, for reasons of practicality. When we're
eventually ready to move it to open source, it wouldn't be using
transportchannelimpl.h. So, do whatever you need to in order to fix the gn
header check, but can you also add a TODO to remove the quic code (and
transportchannelimpl.h)? If we need to use it later we can get it from the git
history, but there's no point in maintaining it currently.

[Taylor Brandstetter, 2017-09-22 14:10:05]

Oh, and lgtm I guess

[kjellander_webrtc, 2017-09-28 08:46:29]

land this now?