Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 3016473002: Remove encoding code from RtcEventLogImpl and use RtcEventLogEncoder instead (Closed)

Created:
2 months ago by eladalon
Modified:
2 months ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, danilchap, AleBzk, peah-webrtc, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc(BackIn2018March), the sun, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove encoding code from RtcEventLogImpl and use RtcEventLogEncoder instead RtcEventLogImpl no longer hard-codes the way encoding is done. It now relies on RtcEventEncoder for it. This gives two benefits: 1. We can decide between the current encoding and the new encoding (which is still WIP) without code duplication (no need for RtcEventLogImplNew). 2. Encoding is done only when the event needs to be written to a file. This both avoids unnecessary encoding of events which don't end up getting written to a file, as well as is useful for the new, delta-based encoding, which is stateful. BUG=webrtc:8111

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -487 lines) Patch
M webrtc/call/call.cc View 8 chunks +22 lines, -9 lines 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 5 chunks +54 lines, -30 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 18 chunks +116 lines, -374 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 13 chunks +75 lines, -41 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/event_log_writer.cc View 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/send_side_bandwidth_estimation.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/delay_based_bwe.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_bitrate_estimator.cc View 4 chunks +13 lines, -6 lines 0 comments Download
M webrtc/modules/pacing/bitrate_prober.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/voice_engine/channel.cc View 11 chunks +49 lines, -15 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
eladalon
PTAL
2 months ago (2017-09-13 15:05:58 UTC) #2
terelius
I think this CL should wait until downstream dependencies are updated.
2 months ago (2017-09-14 08:12:16 UTC) #3
eladalon
2 months ago (2017-09-14 08:56:48 UTC) #4
On 2017/09/14 08:12:16, terelius wrote:
> I think this CL should wait until downstream dependencies are updated.

Summarizing offline discussion:
The changes in this CL (and the other CLs in the stack) do not change the output
to the file. We can land this before changing downstream.

Powered by Google App Engine
This is Rietveld efc10ee0f