Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(16)

Issue 3015743002: Fixes two connection issues with memory_infra_remote_dump. (Closed)

Created:
1 year, 9 months ago by alokp
Modified:
1 year, 9 months ago
Reviewers:
benjhayden
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Fixes two connection issues with memory_infra_remote_dump. 1. Uses websocket-client.create_connection directly. This broke in rdada7e203, which updated the name to use websocket.py under telemetry without updating the import path. 2. Connects to secure devtools browser target URL. This works for content_shell that do not expose browser target.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tracing/bin/memory_infra_remote_dump View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alokp
1 year, 9 months ago (2017-09-27 21:00:45 UTC) #2
benjhayden
Can you either remove the BUG= line from the CL description or link to a ...
1 year, 9 months ago (2017-09-27 22:31:28 UTC) #3
alokp
On 2017/09/27 22:31:28, benjhayden wrote: > Can you either remove the BUG= line from the ...
1 year, 9 months ago (2017-09-27 22:37:54 UTC) #5
alokp
BTW, how do you land catapult patches? I tried git-cl land but I am getting ...
1 year, 9 months ago (2017-09-27 22:40:16 UTC) #6
benjhayden
1 year, 9 months ago (2017-09-27 22:44:44 UTC) #7
On 2017/09/27 at 22:40:16, alokp wrote:
> BTW, how do you land catapult patches?
> 
> I tried git-cl land but I am getting the following error:
> Fetching origin/refs/heads/master...
> Cherry-picking commit on top of latest refs/heads/master
> fatal: remote error: Upload denied for project
'external/github.com/catapult-project/catapult'

I forwarded an email to you about Catapult moving to gerrit today. It looks like
you'll need to re-upload this CL to gerrit.

Powered by Google App Engine
This is Rietveld 408576698