Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 3015603002: [Clean up] Remove code related to install test ca in Telemetry (Closed)

Created:
3 years, 3 months ago by nednguyen
Modified:
3 years, 3 months ago
Reviewers:
xunjieli
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Clean up] Remove code related to install test ca in Telemetry Now that we uses "--ignore-certificate-errors-spki-list" flag for Chrome, there is no longer the need to install test ca on the device. BUG=chromium:766278 Review-Url: https://chromiumcodereview.appspot.com/3015603002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/32f27619a8343013842acea400d3a084c12cdf9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -132 lines) Patch
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/android_platform_backend.py View 3 chunks +0 lines, -40 lines 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend.py View 4 chunks +0 lines, -32 lines 0 comments Download
M telemetry/telemetry/internal/platform/platform_backend.py View 1 chunk +0 lines, -13 lines 0 comments Download
M telemetry/telemetry/internal/util/webpagereplay_go_server.py View 1 chunk +0 lines, -45 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
nednguyen
3 years, 3 months ago (2017-09-18 23:11:29 UTC) #2
xunjieli
LGTM. I am planning to leave the root CA install utility in WPRGo as it ...
3 years, 3 months ago (2017-09-19 13:33:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3015603002/1
3 years, 3 months ago (2017-09-19 13:35:09 UTC) #9
commit-bot: I haz the power
3 years, 3 months ago (2017-09-19 13:36:56 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698