Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 3015433002: Allow passing null for RTCcodecSpecific info in encoder callback.

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by kthelgason
Modified:
2 weeks, 6 days ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Allow passing null for RTCcodecSpecific info in encoder callback. BUG=None

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h View 1 1 chunk +1 line, -1 line 0 comments Download
Trybot results:  presubmit   mac_baremetal   win_dbg   linux_gcc_rel   linux_arm64_dbg   linux_libfuzzer_rel   win_x64_rel   mac_compile_dbg   win_msvc_rel   ios64_sim_ios9_dbg   android_compile_x86_dbg   linux_asan   android_dbg   android_more_configs   ios_rel   ios_arm64_dbg   win_clang_rel   linux_ubsan_vptr   mac_asan   linux_rel   linux_arm64_rel   ios_dbg   linux_more_configs   mac_rel   linux32_arm_rel   linux_compile_dbg   win_baremetal   ios64_sim_ios10_dbg   win_x64_clang_rel   linux_ubsan   linux_tsan2   mac_baremetal   linux_baremetal   win_rel   linux32_arm_dbg   android_rel   ios32_sim_ios9_dbg   win_x64_clang_dbg   android_compile_x64_dbg   linux_memcheck   win_x64_dbg   android_arm64_rel   win_clang_dbg   ios_api_framework   android_compile_x86_rel   android_compile_mips_dbg   linux_msan   presubmit   ios_arm64_rel   win_x64_dbg   mac_baremetal   android_compile_x64_dbg   android_dbg   linux32_arm_dbg   linux_msan   ios_dbg   win_clang_dbg   linux_libfuzzer_rel   android_arm64_rel   linux_more_configs   android_more_configs   mac_rel   win_msvc_rel   mac_compile_dbg   win_clang_rel   linux_rel   win_x64_rel   win_baremetal   ios64_sim_ios9_dbg   linux_ubsan_vptr   ios32_sim_ios9_dbg   linux_asan   linux_gcc_rel   ios_api_framework   win_rel   linux32_arm_rel   win_x64_clang_rel   linux_arm64_rel   mac_asan   ios64_sim_ios10_dbg   ios_rel   android_compile_mips_dbg   linux_baremetal   ios_arm64_rel   win_x64_clang_dbg   linux_memcheck   android_rel   linux_compile_dbg   presubmit   android_compile_x86_dbg   linux_ubsan  Sign in to try more bots
Commit queue not available (can’t edit this change).

Messages

Total messages: 15 (11 generated)
kthelgason
Make sure to be sitting down for this one!
1 month ago (2017-09-13 07:24:30 UTC) #8
magjed_webrtc
lgtm :)
1 month ago (2017-09-14 10:25:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3015433002/20001
2 weeks, 6 days ago (2017-09-28 13:48:04 UTC) #13
commit-bot: I haz the power
2 weeks, 6 days ago (2017-09-28 13:52:34 UTC) #15 
Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/25373)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa