Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 3014543002: Fix Gn untracked headers in webrtc/call

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by charujain1
Modified:
2 weeks, 6 days ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, the sun, mflodman, phoglund
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Gn untracked headers in webrtc/call BUG=webrtc:7641 CQ_INCLUDE_TRYBOTS=master.internal.tryserver.corp.webrtc:linux_internal Review-Url: https://codereview.webrtc.org/3013063002 Cr-Commit-Position: refs/heads/master@{#19824}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased. #

Patch Set 3 : added missing dependency #

Total comments: 2

Messages

Total messages: 10 (4 generated)
charujain
https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn File webrtc/call/BUILD.gn (right): https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn#newcode91 webrtc/call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") { Ideally, this should be included in "call" ...
1 month ago (2017-09-14 15:32:11 UTC) #3
charujain
On 2017/09/14 15:32:11, charujain wrote: > https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn > File webrtc/call/BUILD.gn (right): > > https://codereview.webrtc.org/3014543002/diff/1/webrtc/call/BUILD.gn#newcode91 > ...
4 weeks, 1 day ago (2017-09-19 08:57:52 UTC) #4
mbonadei
https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn File call/BUILD.gn (right): https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn#newcode91 call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") { Is it possible to move this into ...
4 weeks, 1 day ago (2017-09-19 09:00:42 UTC) #5
kjellander_webrtc
https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn File call/BUILD.gn (right): https://codereview.webrtc.org/3014543002/diff/40001/call/BUILD.gn#newcode91 call/BUILD.gn:91: rtc_source_set("bitrate_allocator_header") { On 2017/09/19 09:00:42, mbonadei wrote: > Is ...
4 weeks, 1 day ago (2017-09-19 16:01:43 UTC) #7
charujain
+stefan for advice
3 weeks, 5 days ago (2017-09-22 11:19:17 UTC) #9
kjellander_webrtc
2 weeks, 6 days ago (2017-09-28 08:46:17 UTC) #10
On 2017/09/22 11:19:17, charujain wrote:
> +stefan for advice

ping
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa