Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 3014503002: RtcEventLog::Create() no longer a friend of RtcEventLogImpl (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 21 hours ago by eladalon
Modified:
4 days, 20 hours ago
Reviewers:
terelius
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

RtcEventLog::Create() no longer a friend of RtcEventLogImpl By making RtcEventLogImpl's ctor public, we remove the necessity to make the function a friend. Visibility of RtcEventLogImpl is still limited to the .cc file. BUG=webrtc:8111

Patch Set 1 #

Patch Set 2 : Piggyback namespace change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -12 lines) Patch
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 4 chunks +3 lines, -12 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Depends on Patchset:

Messages

Total messages: 3 (1 generated)
eladalon
PTAL
5 days, 21 hours ago (2017-09-13 14:43:37 UTC) #2
eladalon
4 days, 20 hours ago (2017-09-14 14:57:45 UTC) #3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b