WebRTC Unity Plugin Rebase

WebRTC Unity Plugin Rebase

1. Change the Video frame interface with Unity to support alpha channel. 
2. Let |audio_only| parameter to only affect sending behavior. Namely, when audio_only is true, the Unity side does not send out video frame, but it does not prevent the peer to send video frame to Unity side.

BUG=webrtc:8261

[qiangchen, 2017-09-18 19:57:50]

Description was changed from

==========
WebRTC Unity Plugin Rebase

BUG=
==========

to

==========
WebRTC Unity Plugin Rebase

BUG=webrtc:8261
==========

[qiangchen, 2017-09-18 19:57:50]

qiangchen@chromium.org changed reviewers:
+ gyzhou@chromium.org

[qiangchen, 2017-09-18 19:58:02]

The CQ bit was checked by qiangchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-18 19:58:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-18 20:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-18 20:24:18]

Dry run: This issue passed the CQ dry run.

[qiangchen, 2017-09-18 21:55:22]

Can you take a look?

[qiangchen, 2017-09-18 22:00:28]

Description was changed from

==========
WebRTC Unity Plugin Rebase

BUG=webrtc:8261
==========

to

==========
WebRTC Unity Plugin Rebase

1. Change the Video frame interface with Unity to support alpha channel. 
2. Let |audio_only| parameter to only affect sending behavior. Namely, when
audio_only is true, the Unity side does not send out video frame, but it does
not prevent the peer to send video frame to Unity side.

BUG=webrtc:8261
==========

[GeorgeZ, 2017-09-19 08:21:20]

Please see my comments.

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/simp...
File examples/unityplugin/simple_peer_connection.cc (right):

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/simp...
examples/unityplugin/simple_peer_connection.cc:427: #if defined(WEBRTC_ANDROID)
Dummy capturer should work but may not the best solution here.

Have you tried mandate to get video and audio only in the receiver side as in 
https://chromium-review.googlesource.com/c/external/webrtc/+/648197. I didn't
test it.

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/unit...
File examples/unityplugin/unity_plugin_apis.h (right):

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/unit...
examples/unityplugin/unity_plugin_apis.h:22: const uint8_t* data_a,
I am not sure whether it makes sense to commit this since alpha channel support
is not in the code base yet. If you do want to check in this, please add
comments to explain this situation.

[qiangchen, 2017-09-19 17:57:45]

is_receiver parameter does not work unfortunately. So let's keep using dummy
capturer.

Add comments on why we put alpha channel in the interface.

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/simp...
File examples/unityplugin/simple_peer_connection.cc (right):

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/simp...
examples/unityplugin/simple_peer_connection.cc:427: #if defined(WEBRTC_ANDROID)
On 2017/09/19 08:21:20, GeorgeZ wrote:
> Dummy capturer should work but may not the best solution here.
> 
> Have you tried mandate to get video and audio only in the receiver side as in 
> https://chromium-review.googlesource.com/c/external/webrtc/+/648197. I didn't
> test it.

Unfortunately, that does not work. I think this property belongs to
FakeConstraint, and thus not working really. The only usage else is in a
unittest.

So far the easiest work-around is make a dummy capturer.

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/unit...
File examples/unityplugin/unity_plugin_apis.h (right):

https://codereview.webrtc.org/3013733002/diff/80001/examples/unityplugin/unit...
examples/unityplugin/unity_plugin_apis.h:22: const uint8_t* data_a,
On 2017/09/19 08:21:20, GeorgeZ wrote:
> I am not sure whether it makes sense to commit this since alpha channel
support
> is not in the code base yet. If you do want to check in this, please add
> comments to explain this situation.

I just want to make the plugin work well with our unity Demo code. With
interface change here, without Emircan's patch, the demo will work with ordinary
camera streaming. If we do not do this, crash will be observed.