Add a comment for 'ensure_diskcache'

Add a comment for 'ensure_diskcache'

A logic which ensuring diskcache is added in previous CL:
https://codereview.chromium.org/1984973002
This CL adds a comment for explaining why this is needed.

BUG=catapult:#2342

Review-Url: https://chromiumcodereview.appspot.com/3013233002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b233ea0e0e23e18000a6e7b6c7232cb67dbee7de

[yukiy, 2017-09-21 07:49:33]

Description was changed from

==========
Add a comment for 'ensure_diskcache'

A logic which ensuring diskcache is added in previous CL:
https://codereview.chromium.org/1984973002/patch/20001/30001
This CL adds a comment for explaining why this is needed.

BUG=catapult:#2342
==========

to

==========
Add a comment for 'ensure_diskcache'

A logic which ensuring diskcache is added in previous CL:
https://codereview.chromium.org/1984973002
This CL adds a comment for explaining why this is needed.

BUG=catapult:#2342
==========

[yukiy, 2017-09-21 07:53:09]

yukiy@google.com changed reviewers:
+ kouhei@chromium.org, nednguyen@google.com, shimazu@chromium.org

[yukiy, 2017-09-21 07:53:09]

As it is suggested in previous CL, I want to add some explanation for
'ensure_diskcache'.
Please check if my comment is right.
PTAL :-)

[kouhei (in TOK), 2017-09-21 08:01:15]

https://codereview.chromium.org/3013233002/diff/1/telemetry/telemetry/page/ca...
File telemetry/telemetry/page/cache_temperature.py (right):

https://codereview.chromium.org/3013233002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:67: # not running on measuring.
DiskCache initialization is performed asynchronously on Chrome start-up.
Ensure that DiskCache is initialized before starting the measurement to avoid
performance skew.
This is done by navigating to an inexistent URL and then wait for the navigation
to complete.
TODO(kouhei) Consider moving this logic to PageCyclerStory

[yukiy, 2017-09-21 08:10:57]

PTAL

https://codereview.chromium.org/3013233002/diff/1/telemetry/telemetry/page/ca...
File telemetry/telemetry/page/cache_temperature.py (right):

https://codereview.chromium.org/3013233002/diff/1/telemetry/telemetry/page/ca...
telemetry/telemetry/page/cache_temperature.py:67: # not running on measuring.
On 2017/09/21 08:01:15, kouhei (in TOK) wrote:
> DiskCache initialization is performed asynchronously on Chrome start-up.
> Ensure that DiskCache is initialized before starting the measurement to avoid
> performance skew.
> This is done by navigating to an inexistent URL and then wait for the
navigation
> to complete.
> TODO(kouhei) Consider moving this logic to PageCyclerStory

Done.

[kouhei (in TOK), 2017-09-21 08:12:10]

lgtm

[nednguyen, 2017-09-21 08:59:34]

lgtm

[shimazu, 2017-09-21 09:05:06]

non-owner lgtm

[yukiy, 2017-09-22 00:10:23]

The CQ bit was checked by yukiy@google.com

[commit-bot: I haz the power, 2017-09-22 00:10:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-09-22 00:42:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1506039023085530,
"parent_rev": "ce556f01f55fd0f0ca38536a6c9a3dd85aa6c41c", "commit_rev":
"b233ea0e0e23e18000a6e7b6c7232cb67dbee7de"}

[commit-bot: I haz the power, 2017-09-22 00:42:27]

Description was changed from

==========
Add a comment for 'ensure_diskcache'

A logic which ensuring diskcache is added in previous CL:
https://codereview.chromium.org/1984973002
This CL adds a comment for explaining why this is needed.

BUG=catapult:#2342
==========

to

==========
Add a comment for 'ensure_diskcache'

A logic which ensuring diskcache is added in previous CL:
https://codereview.chromium.org/1984973002
This CL adds a comment for explaining why this is needed.

BUG=catapult:#2342

Review-Url: https://chromiumcodereview.appspot.com/3013233002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-09-22 00:42:28]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...