Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 3013043002: [devil] Update chromium build target deps. (Closed)

Created:
3 years, 3 months ago by jbudorick
Modified:
3 years, 3 months ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cleaning up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M devil/devil/devil_dependencies.json View 1 6 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
jbudorick
3 years, 3 months ago (2017-09-12 16:38:13 UTC) #2
aluo1
lgtm
3 years, 3 months ago (2017-09-13 00:16:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3013043002/20001
3 years, 3 months ago (2017-09-19 13:30:31 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 3 months ago (2017-09-19 13:30:33 UTC) #8
jbudorick
3 years, 3 months ago (2017-09-19 13:31:47 UTC) #10
rnephew (Reviews Here)
On 2017/09/19 13:31:47, jbudorick wrote: lgtm
3 years, 3 months ago (2017-09-19 13:52:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3013043002/20001
3 years, 3 months ago (2017-09-19 13:56:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/d45d1a86b880ae2e549f3f45a2f62f4ed212d24f
3 years, 3 months ago (2017-09-19 14:27:48 UTC) #16
jbudorick
3 years, 3 months ago (2017-09-20 18:35:59 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/3018583002/ by jbudorick@chromium.org.

The reason for reverting is: Causing issues on the chromedriver bot,
https://bugs.chromium.org/p/chromium/issues/detail?id=767068.

Powered by Google App Engine
This is Rietveld 408576698