Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 3012213002: tracing: Add private footprint (Closed)

Created:
3 years, 3 months ago by hjd
Modified:
3 years, 3 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

tracing: Add private footprint Private footprint is a cross-platform, consistent, validated measurement of the amount of memory a process is using which is: - private - non-discardable - anonymous [not backed by a file] - Either resident, compressed, or swapped This plumbs it through Tracing and adds it to the memory metric definitions. BUG=chromium:737325 Review-Url: https://chromiumcodereview.appspot.com/3012213002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b9a4b34443ef5b93696e0968b4b6884c074acc37

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -33 lines) Patch
M tracing/tracing/extras/importer/trace_event_importer.html View 1 chunk +6 lines, -0 lines 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric.html View 2 chunks +15 lines, -0 lines 0 comments Download
M tracing/tracing/metrics/system_health/memory_metric_test.html View 5 chunks +29 lines, -3 lines 0 comments Download
M tracing/tracing/model/process_memory_dump.html View 1 chunk +1 line, -0 lines 0 comments Download
M tracing/tracing/ui/analysis/container_memory_dump_sub_view_test.html View 7 chunks +9 lines, -9 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html View 11 chunks +26 lines, -20 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_sub_view_test_utils.html View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
hjd_google
ptal, thanks! :)
3 years, 3 months ago (2017-09-12 17:11:09 UTC) #2
benjhayden
lgtm
3 years, 3 months ago (2017-09-12 17:40:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3012213002/1
3 years, 3 months ago (2017-09-12 17:41:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/b9a4b34443ef5b93696e0968b4b6884c074acc37
3 years, 3 months ago (2017-09-12 18:15:32 UTC) #8
erikchen
3 years, 3 months ago (2017-09-12 22:09:02 UTC) #10
Message was sent while issue was closed.
Awesome thanks! lgtm

Powered by Google App Engine
This is Rietveld 408576698