Description was changed from ========== Adding time profiling support to AudioFrame Adding time profiling support ...
3 years, 4 months ago
(2017-09-12 08:34:47 UTC)
#1
Description was changed from
==========
Adding time profiling support to AudioFrame
Adding time profiling support to AudioFrame
Adding profile timestamps to AudioFrame
BUG=
==========
to
==========
Adding time profiling support to AudioFrame
BUG=webrtc:8206
==========
https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h File webrtc/modules/include/module_common_types.h (right): https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module_common_types.h#newcode385 webrtc/modules/include/module_common_types.h:385: // by design. Also, rtc::Optional is not used since ...
3 years, 4 months ago
(2017-09-15 17:52:30 UTC)
#9
https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
File webrtc/modules/include/module_common_types.h (right):
https://codereview.webrtc.org/3012183002/diff/1/webrtc/modules/include/module...
webrtc/modules/include/module_common_types.h:385: // by design. Also,
rtc::Optional is not used since it will cause a "complex
On 2017/09/15 13:33:57, henrika_webrtc wrote:
> IMHO, adding a cc-file for this functionality only feels like overkill.
If build targets are set up properly (as they should be, and almost always are
nowadays), adding a .cc file is very little work. So if using Optional is the
right thing to do, don't avoid it just because you'll need a .cc file.
guptaromi2529
http://printablecalendartemplates.com/official-business-letter-example/ Find here all templates
3 years, 4 months ago
(2017-09-28 04:44:03 UTC)
#10
Issue 3012183002: Adding time profiling support to AudioFrame
Created 3 years, 4 months ago by henrika_webrtc
Modified 3 years, 4 months ago
Reviewers: hlundin-webrtc, kwiberg-webrtc
Base URL:
Comments: 13