Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Issue 3012143003: Use --ignore-certificate-errors for webview (Closed)

Created:
3 years, 3 months ago by nednguyen
Modified:
3 years, 3 months ago
Reviewers:
perezju, xunjieli
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M telemetry/telemetry/internal/backends/chrome/android_browser_backend.py View 2 chunks +7 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py View 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
nednguyen
3 years, 3 months ago (2017-09-11 15:54:51 UTC) #2
xunjieli
LGTM. Thanks, Ned! It will be nice if we have some CQ coverage of WebView ...
3 years, 3 months ago (2017-09-11 15:59:41 UTC) #5
nednguyen
On 2017/09/11 15:59:41, xunjieli wrote: > LGTM. Thanks, Ned! > > It will be nice ...
3 years, 3 months ago (2017-09-11 16:00:51 UTC) #6
perezju
lgtm Finally managed to test this on Monochrome on Android N and seems to fix ...
3 years, 3 months ago (2017-09-11 16:09:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3012143003/1
3 years, 3 months ago (2017-09-11 16:14:59 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/aca6ca9eacf53d6d12f599ba6b9011951fde2017
3 years, 3 months ago (2017-09-11 16:56:54 UTC) #13
xunjieli
On 2017/09/11 16:09:58, perezju wrote: > lgtm > > Finally managed to test this on ...
3 years, 3 months ago (2017-09-11 17:04:31 UTC) #14
jbudorick
3 years, 3 months ago (2017-09-11 19:09:35 UTC) #15
Message was sent while issue was closed.
On 2017/09/11 16:09:58, perezju wrote:
> lgtm
> 
> Finally managed to test this on Monochrome on Android N and seems to fix the
> issue (confirmed fails on catapult master, and works with this CL applied).
> 
> Couldn't manage to test SystemWebview on Android M, like the bots run, since I
> don't seem to have the right kind of device; but hopefully this should work
> there too.
> 
> On 2017/09/11 16:00:51, nednguyen wrote:
> > On 2017/09/11 15:59:41, xunjieli wrote:
> > > LGTM. Thanks, Ned!
> > > 
> > > It will be nice if we have some CQ coverage of WebView perf tests.
> > 
> > I totally agree. Juan: do you have any insights why we don't have
> > telemetry_perf_unittests on webview on chromium CQ?
> 
> No idea. +jbudorick, any comments on that?

I don't know of any particular reason.

Powered by Google App Engine
This is Rietveld 408576698