telemetry/telemetry/page/shared_page_state.py - Issue 3011293002: Allow pages to set custom options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 3011293002: Allow pages to set custom options. (Closed)

Patch Set: Add as argument to constructor instead. Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/page/shared_page_state.py

diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py

index 834bdf13c1f859340e2ba6d153b43549f3013550..a2daeb23ce4e504cc1b6dde455d56b460c6c1cb7 100644

--- a/telemetry/telemetry/page/shared_page_state.py

+++ b/telemetry/telemetry/page/shared_page_state.py

@@ -204,6 +204,8 @@ class SharedPageState(story_module.SharedState):

self._test.WillStartBrowser(self.platform)

if page.startup_url:

self._finder_options.browser_options.startup_url = page.startup_url

+ self._finder_options.browser_options.AppendExtraBrowserArgs(

+ page.extra_browser_args)

self._browser = self._possible_browser.Create(self._finder_options)

self._test.DidStartBrowser(self.browser)

« no previous file with comments | « telemetry/telemetry/page/__init__.py ('k') | no next file » | no next file with comments »