Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: telemetry/telemetry/page/__init__.py

Issue 3011293002: Allow pages to set custom options. (Closed)
Patch Set: Add as argument to constructor instead. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/page/__init__.py
diff --git a/telemetry/telemetry/page/__init__.py b/telemetry/telemetry/page/__init__.py
index 3b5ae512f94f072d10bdf3e6284d5d57e61a6c12..1f9b5a5795f564749fdb732af109c43de550343d 100644
--- a/telemetry/telemetry/page/__init__.py
+++ b/telemetry/telemetry/page/__init__.py
@@ -25,7 +25,8 @@ class Page(story.Story):
grouping_keys=None,
cache_temperature=cache_temperature_module.ANY,
traffic_setting=traffic_setting_module.NONE,
- platform_specific=False):
+ platform_specific=False,
+ extra_browser_args=None):
self._url = url
super(Page, self).__init__(
@@ -69,6 +70,7 @@ class Page(story.Story):
self.skip_waits = False
self.script_to_evaluate_on_commit = None
self._SchemeErrorCheck()
+ self._extra_browser_args = extra_browser_args or []
@property
def credentials_path(self):
@@ -86,6 +88,10 @@ class Page(story.Story):
def startup_url(self):
return self._startup_url
+ @property
+ def extra_browser_args(self):
+ return self._extra_browser_args
+
def _SchemeErrorCheck(self):
if not self._scheme:
raise ValueError('Must prepend the URL with scheme (e.g. file://)')
« no previous file with comments | « no previous file | telemetry/telemetry/page/shared_page_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698