Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(61)

Issue 3010373002: Removing webrtc/config.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 days, 21 hours ago by mbonadei
Modified:
1 day, 2 hours ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing webrtc/config.h The content of webrtc/config.h has been moved to webrtc/api/rtpparameters.h, webrtc/call/rtp_config.h and webrtc/call/video_config.h. BUG=webrtc:5876 NOTRY=True

Patch Set 1 #

Patch Set 2 : Removing comment regarding config.h #

Patch Set 3 : testing chromium trybots #

Patch Set 4 : Removing header (chromium trybots are green) #

Patch Set 5 : Removing config.h from BUILD.gn #

Patch Set 6 : Fixing commit author #

Patch Set 7 : rebasing #

Patch Set 8 : rebasing (again) #

Patch Set 9 : Removing webrtc/config.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M webrtc/BUILD.gn View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/rtpparameters.h View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/config.h View 3 1 chunk +0 lines, -19 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 20 (14 generated)
mbonadei
5 days, 17 hours ago (2017-09-13 18:13:32 UTC) #3
stefan-webrtc
lgtm
5 days, 4 hours ago (2017-09-14 06:54:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010373002/120001
5 days, 2 hours ago (2017-09-14 08:59:41 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
5 days, 2 hours ago (2017-09-14 09:02:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010373002/140001
5 days, 2 hours ago (2017-09-14 09:21:11 UTC) #15
commit-bot: I haz the power
5 days, 2 hours ago (2017-09-14 09:24:50 UTC) #20
Failed to commit the patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b