Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: tracing/tracing/value/ui/histogram_set_table_row.html

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/ui/histogram_set_table_row.html
diff --git a/tracing/tracing/value/ui/histogram_set_table_row.html b/tracing/tracing/value/ui/histogram_set_table_row.html
index 704c2d8be2002db1c68ae8f10014a36c99d8781c..0973924cf1f78645910bd2826c74a4317a8f6920 100644
--- a/tracing/tracing/value/ui/histogram_set_table_row.html
+++ b/tracing/tracing/value/ui/histogram_set_table_row.html
@@ -17,9 +17,10 @@ tr.exportTo('tr.v.ui', function() {
* @param {!Element} baseTable tr-ui-b-table
* @param {!tr.v.ui.HistogramSetViewState} rootViewState
*/
- constructor(hierarchy, baseTable, rootViewState) {
+ constructor(hierarchy, baseTable, histograms, rootViewState) {
this.hierarchy_ = hierarchy;
this.baseTable_ = baseTable;
+ this.histograms_ = histograms;
this.rootViewState_ = rootViewState;
this.viewState_ = new tr.v.ui.HistogramSetTableRowState();
this.viewState_.addUpdateListener(this.onViewStateUpdate_.bind(this));
@@ -32,7 +33,7 @@ tr.exportTo('tr.v.ui', function() {
// listening to viewState, so avoid the overhead of dispatching an event.
for (const subHierarchy of hierarchy.subRows) {
const subRow = new HistogramSetTableRow(
- subHierarchy, baseTable, rootViewState);
+ subHierarchy, baseTable, histograms, rootViewState);
this.subRows_.push(subRow);
this.viewState.subRows.set(subRow.name, subRow.viewState);
}
@@ -183,7 +184,8 @@ tr.exportTo('tr.v.ui', function() {
getCell(columnName) {
if (this.cells.has(columnName)) return this.cells.get(columnName);
const cell = document.createElement('tr-v-ui-histogram-set-table-cell');
- cell.build(this, columnName, this.viewState.cells.get(columnName));
+ cell.build(this, columnName, this.histograms_,
+ this.viewState.cells.get(columnName));
this.cells.set(columnName, cell);
return cell;
}
« no previous file with comments | « tracing/tracing/value/ui/histogram_set_table_cell.html ('k') | tracing/tracing/value/ui/histogram_set_table_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698