Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: tracing/tracing/value/ui/histogram_set_table_cell.html

Issue 3009553002: Refactor Histogram relationship diagnostics. (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/ui/histogram_set_table_cell.html
diff --git a/tracing/tracing/value/ui/histogram_set_table_cell.html b/tracing/tracing/value/ui/histogram_set_table_cell.html
index 20a5b4be256dcba409d259529b53492cda98c7bd..d486eae3983f19db5bd926b99d69365e8fa284d9 100644
--- a/tracing/tracing/value/ui/histogram_set_table_cell.html
+++ b/tracing/tracing/value/ui/histogram_set_table_cell.html
@@ -126,9 +126,10 @@ tr.exportTo('tr.v.ui', function() {
// lifetimes are the same as |this|.
},
- build(row, displayLabel, viewState) {
+ build(row, displayLabel, histograms, viewState) {
this.row_ = row;
this.displayLabel_ = displayLabel;
+ this.histograms_ = histograms;
this.viewState_ = viewState;
this.histogram_ = this.row.columns.get(displayLabel);
@@ -218,8 +219,8 @@ tr.exportTo('tr.v.ui', function() {
this.histogramSpan_ = document.createElement('tr-v-ui-histogram-span');
this.histogramSpan_.rowState = this.row.viewState;
this.histogramSpan_.viewState = this.viewState;
- this.histogramSpan_.referenceHistogram = this.referenceHistogram;
- this.histogramSpan_.histogram = this.histogram;
+ this.histogramSpan_.build(
+ this.histogram, this.referenceHistogram, this.histograms_);
this.histogramSpan_.alpha = this.row.rootViewState.alpha;
this.$.histogram.appendChild(this.histogramSpan_);
}
@@ -318,9 +319,9 @@ tr.exportTo('tr.v.ui', function() {
const referenceHistogram = this.referenceHistogram;
if (this.histogramSpan_) {
- // Reset in case HistogramSetViewState.referenceDisplayLabel changed.
- this.histogramSpan_.referenceHistogram = referenceHistogram;
-
+ // Rebuild in case HistogramSetViewState.referenceDisplayLabel changed.
+ this.histogramSpan_.build(
+ this.histogram, this.referenceHistogram, this.histograms_);
this.histogramSpan_.alpha = this.row.rootViewState.alpha;
}
« no previous file with comments | « tracing/tracing/value/ui/histogram_set_table.html ('k') | tracing/tracing/value/ui/histogram_set_table_row.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698