Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: web_page_replay_go/README.md

Issue 3009313002: Revert of [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: web_page_replay_go/README.md
diff --git a/web_page_replay_go/README.md b/web_page_replay_go/README.md
index 114150a8edc9089a3dd0255b1cd9ad080a4616c1..d4e74da99fdb565ceb911bb3f40977a3de56e627 100644
--- a/web_page_replay_go/README.md
+++ b/web_page_replay_go/README.md
@@ -33,7 +33,6 @@
```
google-chrome-beta --user-data-dir=$foo \
--host-resolver-rules="MAP *:80 127.0.0.1:8080,MAP *:443 127.0.0.1:8081,EXCLUDE localhost"
- --ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I=
```
... wait for record servers to start
@@ -48,8 +47,7 @@
* Terminal 2:
```
google-chrome-beta --user-data-dir=$bar \
- --host-resolver-rules="MAP *:80 127.0.0.1:8080,MAP *:443 127.0.0.1:8081,EXCLUDE localhost"
- --ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I=
+ --host-resolver-rules="MAP *:80 127.0.0.1:8080,MAP *:443 127.0.0.1:8081,EXCLUDE localhost"`
```
... wait for replay servers to start
@@ -69,20 +67,18 @@
* Set up command line arguments
```
-build/android/adb_chrome_public_command_line --host-resolver-rules="MAP *:80 127.0.0.1:8080,MAP *:443 127.0.0.1:8081,EXCLUDE localhost" \
- --ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I=
+build/android/adb_chrome_public_command_line '--host-resolver-rules="MAP *:80 127.0.0.1:8080,MAP *:443 127.0.0.1:8081,EXCLUDE localhost"'
```
* Run wpr.go as usual on the linux machine
-### (Optional) Installing test root CA
+### Installing test root CA
WebPageReplay uses self signed certificates for Https requests. To make Chrome
-trust these certificates, you can use --ignore-certificate-errors-spki-list
-like above. If that doesn't work, you may try installing a test certificate
-authority as a local trust anchor. **Note:** Please do this with care because
-installing the test root CA compromises your machine. This is currently only
-supported on Linux and Android.
+trust these certificates, you can install a test certificate authority as a
+local trust anchor. **Note:** Please do this with care because installing the
+test root CA compromises your machine. This is currently only supported on
+Linux and Android.
Installing the test CA. Specify a `--android_device_id` if you'd like to install
the root CA on an android device.
@@ -110,7 +106,6 @@
```
google-chrome-beta --user-data-dir=$foo \
--host-resolver-rules="MAP *:443 127.0.0.1:8081,EXCLUDE localhost" \
- --ignore-certificate-errors-spki-list=PhrPvGIaAMmd29hj8BCZOq096yj7uMpRNHpn5PDxI6I= \
--proxy-server=http=https://127.0.0.1:8082 \
--trusted-spdy-proxy=127.0.0.1:8082
```
@@ -138,15 +133,6 @@
go test webpagereplay -run ''
```
-## Generate public key hash for --ignore-certificate-errors-spki-list
-wpr_public_hash.txt is generated from wpr_cert.pem using the command below.
-```
-openssl x509 -noout -pubkey -in wpr_cert.pem | \
-openssl pkey -pubin -outform der | \
-openssl dgst -sha256 -binary | \
-base64
-```
-
## Contribute
Please read [contributor's guide][contribute]. We use the Catapult
[issue tracker][tracker] for bugs and features. Once your change is reviewed

Powered by Google App Engine
This is Rietveld 408576698