Revert of [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors

ABANDONED

Revert of [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors (patchset #9 id:220001 of https://chromiumcodereview.appspot.com/3003143002/ )

Reason for revert:
Broke perf tests for webview crbug.com/763880

Original issue's description:
> [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors
> 
> --ignore-certificate-errors-spki-list is a new flag that can be used to
> selectively bypass certificate errors. This flag avoid the downsides of
> the old --ignore-certificate-errors flag (which makes Chrome to skip 
> disk cache and re-establish socket connections) For more details, please 
> see the linked bug below.
> 
> BUG=chromium:753948
> 
> Review-Url: https://chromiumcodereview.appspot.com/3003143002
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/724bb776bcdea642a5bc9cc20fe14bb0282b4900

TBR=nednguyen@google.com,simonhatch@chromium.org,xunjieli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:753948

[perezju, 2017-09-11 15:12:13]

The CQ bit was checked by perezju@chromium.org

[perezju, 2017-09-11 15:12:14]

Created Revert of [Telemetry] Use --ignore-certificate-errors-spki-list to
bypass cert errors

[commit-bot: I haz the power, 2017-09-11 15:12:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nednguyen, 2017-09-11 15:14:17]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2017-09-11 15:14:38]

On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> CQ is trying da patch.
> 
> Follow status at:
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Let not revert this since the revert will cause lots of perf regressions

[xunjieli, 2017-09-11 15:18:12]

On 2017/09/11 15:14:38, nednguyen wrote:
> On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> > CQ is trying da patch.
> > 
> > Follow status at:
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> 
> Let not revert this since the revert will cause lots of perf regressions

I agree. Can you add --ignore-certificate-errors to webview only?

[perezju, 2017-09-11 15:24:06]

On 2017/09/11 15:18:12, xunjieli wrote:
> On 2017/09/11 15:14:38, nednguyen wrote:
> > On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> > > CQ is trying da patch.
> > > 
> > > Follow status at:
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > 
> > Let not revert this since the revert will cause lots of perf regressions
> 
> I agree. Can you add --ignore-certificate-errors to webview only?

If you think that change is enough, and can quickly test and send out a CL with
a fix instead I'm OK with it.

[xunjieli, 2017-09-11 15:26:02]

On 2017/09/11 15:24:06, perezju wrote:
> On 2017/09/11 15:18:12, xunjieli wrote:
> > On 2017/09/11 15:14:38, nednguyen wrote:
> > > On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> > > > CQ is trying da patch.
> > > > 
> > > > Follow status at:
> > > >
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > > 
> > > Let not revert this since the revert will cause lots of perf regressions
> > 
> > I agree. Can you add --ignore-certificate-errors to webview only?
> 
> If you think that change is enough, and can quickly test and send out a CL
with
> a fix instead I'm OK with it.

I can do it. But I don't have a webview setup ready. Also WebView is not on CQ.

[nednguyen, 2017-09-11 15:26:20]

On 2017/09/11 15:24:06, perezju wrote:
> On 2017/09/11 15:18:12, xunjieli wrote:
> > On 2017/09/11 15:14:38, nednguyen wrote:
> > > On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> > > > CQ is trying da patch.
> > > > 
> > > > Follow status at:
> > > >
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > > 
> > > Let not revert this since the revert will cause lots of perf regressions
> > 
> > I agree. Can you add --ignore-certificate-errors to webview only?
> 
> If you think that change is enough, and can quickly test and send out a CL
with
> a fix instead I'm OK with it.

Since Helen is not well versed with the webview part, I can make the CL. Though
I don't have a test phone (working from home due to my injury these days), so
can you help me with verifying, Juan?

[perezju, 2017-09-11 15:29:54]

On 2017/09/11 15:26:20, nednguyen wrote:
> On 2017/09/11 15:24:06, perezju wrote:
> > On 2017/09/11 15:18:12, xunjieli wrote:
> > > On 2017/09/11 15:14:38, nednguyen wrote:
> > > > On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> > > > > CQ is trying da patch.
> > > > > 
> > > > > Follow status at:
> > > > >
> > > >
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > > > 
> > > > Let not revert this since the revert will cause lots of perf regressions
> > > 
> > > I agree. Can you add --ignore-certificate-errors to webview only?
> > 
> > If you think that change is enough, and can quickly test and send out a CL
> with
> > a fix instead I'm OK with it.
> 
> Since Helen is not well versed with the webview part, I can make the CL.
Though
> I don't have a test phone (working from home due to my injury these days), so
> can you help me with verifying, Juan?

I was actually having troubles locally setting up a device to run WebView tests
on it (for this bug itself).

Will try to give it a go again and see if I can get a device ready to test.

[xunjieli, 2017-09-11 15:33:24]

On 2017/09/11 15:29:54, perezju wrote:
> On 2017/09/11 15:26:20, nednguyen wrote:
> > On 2017/09/11 15:24:06, perezju wrote:
> > > On 2017/09/11 15:18:12, xunjieli wrote:
> > > > On 2017/09/11 15:14:38, nednguyen wrote:
> > > > > On 2017/09/11 15:12:25, commit-bot: I haz the power wrote:
> > > > > > CQ is trying da patch.
> > > > > > 
> > > > > > Follow status at:
> > > > > >
> > > > >
> > > >
> > >
> >
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
> > > > > 
> > > > > Let not revert this since the revert will cause lots of perf
regressions
> > > > 
> > > > I agree. Can you add --ignore-certificate-errors to webview only?
> > > 
> > > If you think that change is enough, and can quickly test and send out a CL
> > with
> > > a fix instead I'm OK with it.
> > 
> > Since Helen is not well versed with the webview part, I can make the CL.
> Though
> > I don't have a test phone (working from home due to my injury these days),
so
> > can you help me with verifying, Juan?
> 
> I was actually having troubles locally setting up a device to run WebView
tests
> on it (for this bug itself).
> 
> Will try to give it a go again and see if I can get a device ready to test.

Thanks! I am surprised that we have memory regressions for WebView when the
pages in fact aren't loading...

[perezju, 2017-09-12 08:09:20]

Description was changed from

==========
Revert of [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert
errors (patchset #9 id:220001 of
https://chromiumcodereview.appspot.com/3003143002/ )

Reason for revert:
Broke perf tests for webview crbug.com/763880

Original issue's description:
> [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors
> 
> --ignore-certificate-errors-spki-list is a new flag that can be used to
> selectively bypass certificate errors. This flag avoid the downsides of
> the old --ignore-certificate-errors flag (which makes Chrome to skip 
> disk cache and re-establish socket connections) For more details, please 
> see the linked bug below.
> 
> BUG=chromium:753948
> 
> Review-Url: https://chromiumcodereview.appspot.com/3003143002
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=nednguyen@google.com,simonhatch@chromium.org,xunjieli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:753948
==========

to

==========
ABANDONED

Revert of [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert
errors (patchset #9 id:220001 of
https://chromiumcodereview.appspot.com/3003143002/ )

Reason for revert:
Broke perf tests for webview crbug.com/763880

Original issue's description:
> [Telemetry] Use --ignore-certificate-errors-spki-list to bypass cert errors
> 
> --ignore-certificate-errors-spki-list is a new flag that can be used to
> selectively bypass certificate errors. This flag avoid the downsides of
> the old --ignore-certificate-errors flag (which makes Chrome to skip 
> disk cache and re-establish socket connections) For more details, please 
> see the linked bug below.
> 
> BUG=chromium:753948
> 
> Review-Url: https://chromiumcodereview.appspot.com/3003143002
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=nednguyen@google.com,simonhatch@chromium.org,xunjieli@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chromium:753948
==========