Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 3008293002: [pinpoint] Show status for every Execution. (Closed)

Created:
3 years, 3 months ago by dtu
Modified:
3 years, 3 months ago
Reviewers:
sullivan, shatch
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[pinpoint] Show status for every Execution. Rough draft of the "flakiness dashboard" UI that shows the pass/fail for each execution. Hovering over a failed execution shows the stack trace in a tooltip. Clicking on each execution gives the execution details. May not work for some edge cases: no 3rd quest (functional bisect), switching between Jobs. Review-Url: https://chromiumcodereview.appspot.com/3008293002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/075ea7a42312c764e655f38224d1f68e11b39b8b

Patch Set 1 #

Patch Set 2 : git d #

Patch Set 3 : iron-selector #

Patch Set 4 : Margins. #

Patch Set 5 : unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -69 lines) Patch
A dashboard/dashboard/pinpoint/elements/execution-status.html View 1 2 3 1 chunk +154 lines, -0 lines 0 comments Download
M dashboard/dashboard/pinpoint/elements/job-page.html View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M dashboard/dashboard/pinpoint/elements/job-page-change-table.html View 1 2 3 chunks +28 lines, -54 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/execution.py View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/find_isolate_test.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/read_value.py View 2 chunks +2 lines, -6 lines 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/run_test.py View 1 chunk +0 lines, -1 line 0 comments Download
M dashboard/dashboard/pinpoint/models/quest/run_test_test.py View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
dtu
Demo: https://dev-dtu-6822c776-dot-pinpoint-dot-chromeperf.appspot.com/job/14a3bf11b80000
3 years, 3 months ago (2017-09-08 04:04:20 UTC) #2
dtu
On 2017/09/08 04:04:20, dtu wrote: > Demo: > https://dev-dtu-6822c776-dot-pinpoint-dot-chromeperf.appspot.com/job/14a3bf11b80000 I think it needs a little ...
3 years, 3 months ago (2017-09-08 06:57:57 UTC) #4
dtu
On 2017/09/08 06:57:57, dtu wrote: > On 2017/09/08 04:04:20, dtu wrote: > > Demo: > ...
3 years, 3 months ago (2017-09-08 17:35:17 UTC) #5
sullivan
lgtm Awesome!
3 years, 3 months ago (2017-09-08 17:48:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3008293002/40001
3 years, 3 months ago (2017-09-08 18:04:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3008293002/60001
3 years, 3 months ago (2017-09-08 18:09:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/9284)
3 years, 3 months ago (2017-09-08 18:15:13 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3008293002/80001
3 years, 3 months ago (2017-09-08 18:49:53 UTC) #17
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 19:21:52 UTC) #20
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698