Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issue 3008223002: Plumb traceUrls through ChartJsonConverter. (Closed)

Created:
3 years, 3 months ago by benjhayden
Modified:
3 years, 3 months ago
Reviewers:
eakuefner, shatch
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -5 lines) Patch
M telemetry/telemetry/internal/results/csv_output_formatter_unittest.py View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/value/trace.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M tracing/tracing/value/chart_json_converter.html View 1 2 chunks +13 lines, -0 lines 0 comments Download
M tracing/tracing/value/chart_json_converter_test.html View 5 chunks +47 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
benjhayden
3 years, 3 months ago (2017-09-08 16:51:12 UTC) #4
eakuefner
lgtm
3 years, 3 months ago (2017-09-11 18:45:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3008223002/60001
3 years, 3 months ago (2017-09-11 18:53:46 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/9320)
3 years, 3 months ago (2017-09-11 19:22:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3008223002/100001
3 years, 3 months ago (2017-09-14 04:20:06 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-09-14 04:51:45 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698