Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 3008203002: Format traceUrls in generic-set-span. (Closed)

Created:
3 years, 3 months ago by benjhayden
Modified:
3 years, 3 months ago
Reviewers:
eakuefner
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Format traceUrls in generic-set-span. Currently, file: URLs are not linkified, and full traceUrls are displayed. This CL linkifies file: URLs and only displays the unique last component of traceUrls. http://www/~benjhayden/3007063002.html BUG=catapult:#2431 Review-Url: https://chromiumcodereview.appspot.com/3008203002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/0cf3924bab2c2f66a412edda35f6e3572bd57623

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -49 lines) Patch
M tracing/tracing/base/utils.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/diagnostic_map_table.html View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/value/ui/generic_set_span.html View 1 2 3 chunks +30 lines, -31 lines 0 comments Download
M tracing/tracing/value/ui/generic_set_span_test.html View 1 chunk +56 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
benjhayden
3 years, 3 months ago (2017-09-06 17:48:12 UTC) #3
eakuefner
lgtm
3 years, 3 months ago (2017-09-06 21:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3008203002/60001
3 years, 3 months ago (2017-09-06 22:29:27 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-06 23:11:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698