Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 3008163002: Revert of "Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker ..." (Closed)

Created:
3 years, 3 months ago by perezju
Modified:
3 years, 3 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished (patchset #8 id:140001 of https://chromiumcodereview.appspot.com/3012573002/ ) Reason for revert: This CL appears to be failing and blocking catapult rolls. See https://catapult-roll.skia.org/ Original issue's description: > Add tab.IsServiceWorkerReadyOrNotRegistered() which tells whether serviceworker registration is finished > > This CL add tab.IsServiceWorkerReadyOrNotRegistered() to check if ServiceWorker registration are completed. > After this CL submitted, IsServiceWorkerReadyOrNotRegistered() will be used in PageCyclerStory.RunPageInteractions(). > > Design doc of perf benchmark for PWA: > https://docs.google.com/document/d/1Nf97CVp1X7aSqvAspyJ7yOCDyr1osUNrnfrGwZ_Yuuo/edit?usp=sharing > > BUG=chromium:736697 > > Review-Url: https://chromiumcodereview.appspot.com/3012573002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/71a6fd36ee38adf53de1293ebc04099dac6b4911 TBR=ksakamoto@google.com,nednguyen@google.com,kouhei@chromium.org,falken@chromium.org,yukiy@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:736697 Review-Url: https://chromiumcodereview.appspot.com/3008163002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4ab7a181db1c7baee9aeeba1cdd0aabbaf06ca3e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -112 lines) Patch
M catapult_build/js_checks.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/internal/browser/tab_unittest.py View 2 chunks +0 lines, -15 lines 0 comments Download
D telemetry/telemetry/internal/browser/wait_for_serviceworker_registration.js View 1 chunk +0 lines, -40 lines 0 comments Download
M telemetry/telemetry/internal/browser/web_contents.py View 4 chunks +1 line, -51 lines 0 comments Download
D telemetry/telemetry/internal/testing/blank.js View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
perezju
Created Revert of Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether serviceworker registration is finished
3 years, 3 months ago (2017-09-05 15:13:51 UTC) #2
perezju
On 2017/09/05 15:13:51, perezju wrote: > Created Revert of Add tab.IsServiceWorkerReadyOrNotRegist() which tells whether > ...
3 years, 3 months ago (2017-09-05 15:21:47 UTC) #5
commit-bot: I haz the power
3 years, 3 months ago (2017-09-05 15:41:45 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698